[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account 
From:       Yuri Nesterenko <yuri.nesterenko () oracle ! com>
Date:       2015-06-02 13:29:57
Message-ID: 556DAFD5.9050700 () oracle ! com
[Download RAW message or body]

Hi Alexander(s),

I have some problems not with this change but
with the routine itself.

As I understand, this change is automatically generated.
The generator script is imperfect. For instance,
it cannot catch dependencies in places like
javax/swing/RepaintManager/6608456/bug6608456.java
where tests depend on reflection to call certain internal methods.
Now, if I add the @modules line myself, manually,
it will be removed on the next run of the script.

How do you suppose to remedy that?

Same thing, sun/awt/datatransfer/DataFlavorComparatorTest.java issue.
Correct modules should be
      @modules java.datatransfer/sun.datatransfer
               java.desktop/sun.awt.datatransfer
You don't have that second line. OK, that's because jdeps
for some reason didn't catch that. Why, all programs have bugs,
and this one will be eventually fixed. But until then,
how can I fix the test? You'll break my fix again --
or every time someone should invest certain amount of manual labor.
Tonight I'm afraid that's you.

Thanks,
-yan

On 06/02/2015 02:31 PM, Alexander Kulyakhtin wrote:
> Hi,
> 
> Could you, please, review the following tests-only changes to the test files from \
> the jdk9/client repository 
> http://cr.openjdk.java.net/~akulyakh/8076468/webrev.02/index.html
> 
> The changes add @modules to the tests to make it possible to run the tests with \
> jake. 
> Best regards,
> Alexander
> 


[prev in list] [next in list] [prev in thread] [next in thread]