[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7
From:       Andrew Brygin <andrew.brygin () oracle ! com>
Date:       2015-04-30 9:08:56
Message-ID: 5541F128.6050908 () oracle ! com
[Download RAW message or body]

Hello Phil,

  the change looks fine to me.

Thanks,
Andrew

On 4/30/2015 12:47 AM, Phil Race wrote:
> Please review the 8u backport of the same
>
> http://cr.openjdk.java.net/~prr/8078331.8u/
>
> I will ease this by noting the following
>
> - I generated the webrev by applying the 9 patch to 8u.
>
> - The changes differ from the JDK 9 patch only in the respect that
> JDk 9 had this one change (by us) that was not backported.
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ae261c9704a6
>
> - Otherwise the patch is identical and I verified this by 'diffing' 
> the 2 patches.
>
> - Furthermore I 'diffed' the resulting 8 files against the 9 files and 
> they are all identical
>
> So the end result is that we will have exactly LCMS 2.7 "FCS/GA" in 
> both JDK 8u60 and JDK 9
>
> I am also running a full JPRT job to make sure there are no build 
> surprises.
>
> -phil.
>
>
> On 04/28/2015 09:39 PM, Andrew Brygin wrote:
>> Hello Phil,
>>
>>  the change looks fine to me.
>>
>> Thanks,
>> Andrew.
>>
>> 29/04/15 00:34, Phil Race wrote:
>>>
>>> On 04/21/2015 03:47 PM, Phil Race wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8078331
>>>> http://cr.openjdk.java.net/~prr/8078331/
>>>>
>>>> These changes are all directly from upstream LCMS.
>>>> It takes us from 2.6 plus a couple of patches to the 2.7 release 
>>>> with the
>>>> upstream version of those patches. Modulo 'white space' we will be
>>>> 100% in sync with the LCMS current release, for perhaps the first 
>>>> time.
>>>>
>>>> I'm running a full JPRT job to validate my local builds.
>>>>
>>>> -phil.
>>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]