[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: Backport :8073699: Memory leak in jdk/src/java/desktop/share/native/libjav
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2015-04-20 19:40:40
Message-ID: 55355638.4030400 () oracle ! com
[Download RAW message or body]

Looks fine.

On 20.04.15 22:07, Andrew Brygin wrote:
> Hi Phil,
>
>  it looks fine to me.
>
> Thanks,
> Andrew
>
> 20/04/15 21:49, Phil Race пишет:
>> Andrew & Sergey,
>>
>> Please review this identical 8u60 backport (diff below) of the JDK 9 
>> fix : http://hg.openjdk.java.net/jdk9/hs/jdk/rev/b7e402c9b183
>>
>> hg diff imageioJPEG.c
>> diff --git a/src/share/native/sun/awt/image/jpeg/imageioJPEG.c 
>> b/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
>> --- a/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
>> +++ b/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
>> @@ -2778,6 +2778,14 @@
>>      pb = &data->pixelBuf;
>>
>>      if (setPixelBuffer(env, pb, buffer) == NOT_OK) {
>> +        if (scale != NULL) {
>> +            for (i = 0; i < numBands; i++) {
>> +                if (scale[i] != NULL) {
>> +                    free(scale[i]);
>> +                }
>> +            }
>> +            free(scale);
>> +        }
>>          return data->abortFlag;  // We already threw an out of 
>> memory exception
>>      }
>>
>> -phil.
>


-- 
Best regards, Sergey.

[prev in list] [next in list] [prev in thread] [next in thread]