[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code
From:       Phil Race <philip.race () oracle ! com>
Date:       2015-04-09 20:26:06
Message-ID: 5526E05E.5010906 () oracle ! com
[Download RAW message or body]

Old "notes to self" from an earlier revision. I'll delete before pushing.

-phil.

On 04/09/2015 12:25 PM, Mandy Chung wrote:
> On 3/25/15 3:48 PM, Phil Race wrote:
>> Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/
> sun/font/XMap.java
>    +            jclass = "JIS0201"; // CHECK
>    +            jclass = "MS950_HKSCS_XP"; // CHECK
> What is the CHECK comment?  Otherwise, looks okay.  Thank you for
> removing java.desktop dependency to jdk.charsets.
>
>
> Mandy


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Old "notes to self" from an earlier
      revision. I'll delete before pushing.<br>
      <br>
      -phil.<br>
      <br>
      On 04/09/2015 12:25 PM, Mandy Chung wrote:<br>
    </div>
    <blockquote cite="mid:5526D222.3080308@oracle.com" type="cite">
      <meta content="text/html; charset=windows-1252"
        http-equiv="Content-Type">
      <div class="moz-cite-prefix">On 3/25/15 3:48 PM, Phil Race wrote:<br>
      </div>
      <blockquote cite="mid:55133B36.5040109@oracle.com" type="cite">Updated

        webrev <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Eprr/8035302.2/">http://cr.openjdk.java.net/~prr/8035302.2/</a>
  <br>
      </blockquote>
      <pre>sun/font/XMap.java
  +            jclass = "JIS0201"; // CHECK
<meta http-equiv="content-type" content="text/html; charset=windows-1252"><span \
class="new">  +            jclass = "MS950_HKSCS_XP"; // CHECK</span> What is the \
CHECK comment?  Otherwise, looks okay.  Thank you for removing java.desktop \
dependency to jdk.charsets.


Mandy
</pre>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic