[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8075942: ArrayIndexOutOfBoundsException in sun.java2d.pisces.Dasher.goTo
From:       Jim Graham <james.graham () oracle ! com>
Date:       2015-04-02 21:13:40
Message-ID: 551DB104.50706 () oracle ! com
[Download RAW message or body]

The fix looks good.  +1

		...jim

On 4/1/15 3:55 PM, Phil Race wrote:
> https://bugs.openjdk.java.net/browse/JDK-8075942
> http://cr.openjdk.java.net/~prr/8075942/
>
> It appears that the amount to grow the array is not taking into account
> that before the System.arraycopy we first store 'type' and increment the
> offset :-
>
> 150                 firstSegmentsBuffer[firstSegidx++] = type;
>
>
> Fix is to add 1 to the amount to grow the array.  "type - 2 + 1" looks
> a bit inefficient but is a closer match to what is being added and I'd
> like to think javac simplifies the expression.
>
> -phil.
[prev in list] [next in list] [prev in thread] [next in thread]