[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] Path2d needRoom very slow for huge paths
From:       Laurent_Bourg�s <bourges.laurent () gmail ! com>
Date:       2015-04-02 20:35:16
Message-ID: CAKjRUT7atYRkjyjaj8ogLXv_C4-svUNq1d0gQrKc8U+Kcf8WiQ () mail ! gmail ! com
[Download RAW message or body]

I can understand to promote the 99% use case (small path) but the
performance penalty is too important to me for large paths....

Let's have jim's point of view as he knows the complete story...

Laurent
Le 2 avr. 2015 19:33, "Phil Race" <philip.race@oracle.com> a écrit :

> I should have paid more attention to the context.
> So it appears that 500 has been the value since 1998 and
> it was made that under this bugid when the code was all
> still in GeneralPath.java
>
> https://bugs.openjdk.java.net/browse/JDK-4134316
>
> prior to that fix it was even smaller
>
> <     static final int INIT_SIZE = 10;
> <     static final int EXPAND_SIZE = 10;
> ---
> >     static final int INIT_SIZE = 20;
> >     static final int EXPAND_MAX = 500;
>
> Looks like something we should get Jim's view on since although
> a lot has changed since 1998 there may be some negative
> consequences he is aware of.
>
> -phil.
>
> On 04/02/2015 10:15 AM, Laurent Bourgčs wrote:
>
>>
>> Phil,
>>
>> Just a short comment:
>>
>> > pisces was originally written for the "ME" environment so I suspect that
>> > it was very conservative in allocating new heap space. That clearly
>> does not
>> > matter so much on desktop so the proportional approach rather than
>> > the fixed size approach seems better. 1/8th seems conservative and
>> > since the results look good so I don't object.
>>
>> I think Path2D is part of the java2d api and seems not related to pisces ?
>>
>> > I think a new bug id would be required as this is another thing that
>> > might be backported to pisces in 8u60.
>>
>> Agreed.
>>
>> Laurent
>>
>>
>

[Attachment #3 (text/html)]

<p dir="ltr">I can understand to promote the 99% use case (small path) but the \
performance penalty is too important to me for large paths....</p> <p \
dir="ltr">Let&#39;s have jim&#39;s point of view as he knows the complete \
story...</p> <p dir="ltr">Laurent</p>
<div class="gmail_quote">Le 2 avr. 2015 19:33, &quot;Phil Race&quot; &lt;<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>&gt; a écrit :<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">I should have paid more attention \
to the context.<br> So it appears that 500 has been the value since 1998 and<br>
it was made that under this bugid when the code was all<br>
still in GeneralPath.java<br>
<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-4134316" \
target="_blank">https://bugs.openjdk.java.net/<u></u>browse/JDK-4134316</a><br> <br>
prior to that fix it was even smaller<br>
<br>
&lt;        static final int INIT_SIZE = 10;<br>
&lt;        static final int EXPAND_SIZE = 10;<br>
---<br>
&gt;        static final int INIT_SIZE = 20;<br>
&gt;        static final int EXPAND_MAX = 500;<br>
<br>
Looks like something we should get Jim&#39;s view on since although<br>
a lot has changed since 1998 there may be some negative<br>
consequences he is aware of.<br>
<br>
-phil.<br>
<br>
On 04/02/2015 10:15 AM, Laurent Bourgčs wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
Phil,<br>
<br>
Just a short comment:<br>
<br>
&gt; pisces was originally written for the &quot;ME&quot; environment so I suspect \
that<br> &gt; it was very conservative in allocating new heap space. That clearly \
does not<br> &gt; matter so much on desktop so the proportional approach rather \
than<br> &gt; the fixed size approach seems better. 1/8th seems conservative and<br>
&gt; since the results look good so I don&#39;t object.<br>
<br>
I think Path2D is part of the java2d api and seems not related to pisces ?<br>
<br>
&gt; I think a new bug id would be required as this is another thing that<br>
&gt; might be backported to pisces in 8u60.<br>
<br>
Agreed.<br>
<br>
Laurent<br>
<br>
</blockquote>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]