[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: JDK-8074096 Disable (most) native warnings in JDK on a per-library basis
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2015-03-09 9:08:54
Message-ID: 54FD6326.4070403 () oracle ! com
[Download RAW message or body]

Thanks, looks good!

/Erik

On 2015-03-06 17:14, Magnus Ihse Bursie wrote:
> On 2015-03-04 14:31, Erik Joelsson wrote:
>> Hello,
>>
>> Really nice to finally see this patch getting done!
>>
>> Only one comment:
>>
>> flags.m4:
>> In the grep expression, could you move the extra [] outside of the 
>> actual command line options to grep so that the command line could be 
>> copied to the shell for debugging in the future? Also, how hard would 
>> it be to instead do AC_COMPILE_IFELSE with a dummy warning to instead 
>> test for capability?
>
> I have updated the fix to use the eminent 
> FLAGS_COMPILER_CHECK_ARGUMENTS instead. :-)
>
> http://cr.openjdk.java.net/~ihse/JDK-8074096-disable-native-warnings/webrev.02 
>
>
> /Magnus
>

[prev in list] [next in list] [prev in thread] [next in thread]