[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request: 4958064 JPGWriter does not throw UnsupportedException when 
From:       Phil Race <philip.race () oracle ! com>
Date:       2015-02-26 20:27:17
Message-ID: 54EF81A5.9030405 () oracle ! com
[Download RAW message or body]

+1

-phil.

On 2/9/2015 5:30 AM, Sergey Bylokhov wrote:
> Hello.
> Please review a small fix for jdk 9.
> The API Doc for ImageWriter.PrepareWriteSequence() claims that this 
> method will throw UnsupportedOperationException when 
> canWriteSequence() returns false. But this does not seem to be 
> happening for JPEG ImageWriter.
> JPG writer has failed to override the method canWriteSequence() and 
> relies on the parent class ImageWriter which returns a 'false' value 
> by default.
> But JPEGImageWriter class has actually implemented the method 
> prepareWriteSequence() and it does not throw 
> UnsupportedOperationException when canWriteSequence() returns false.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-4958064
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/4958064/webrev%2c01
>

[prev in list] [next in list] [prev in thread] [next in thread]