[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager
From:       Phil Race <philip.race () oracle ! com>
Date:       2015-01-23 18:48:11
Message-ID: 54C2976B.2030200 () oracle ! com
[Download RAW message or body]

On 01/20/2015 07:42 AM, Roman Kennke wrote:
> I already sent that patch to awt-dev for review, a while ago:
>
> http://mail.openjdk.java.net/pipermail/awt-dev/2015-January/008819.html
>
> I got no reply, so I'm sending it here, maybe it's a better fit? ;-)

font related discussions should go to 2d-dev.
The change looks OK. But test it as much as
you can. The previous re-factoring in JDK7
had a fairly long bug trail.

- Do submit a bug and mark it noreg-cleanup
- Do get a 2nd reviewer before committing.
- Do update the (C) in the new file to 2015 since the clock ticked
since you first sent the review.

-phil.


>
>
> Hello,
>
> I am currently working on a port of AWT/Java2D to DirectFB (using
> Caciocavallo [1] as a porting layer).
>
> I hit one obstacle that is the X11FontManager. I want to use fontconfig
> to work with fonts, but can't use anything X11.
>
> I refactored X11FontManager and related classes and native code to avoid
> calling anything X11 specific. Basically I created a superclass of
> X11FontManager called FcFontManager that does all the fontconfig related
> stuff, and use that in my backend. The changes should not affect the X11
> implementation.
>
> Can you please review the changes here:
>
> http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.00/
>
> I would like to push this into jdk9-client if you think it's ok.
>
> Best regards,
> Roman
>
> [1] http://openjdk.java.net/projects/caciocavallo/
>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]