[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis
From:       Mario Torre <neugens.limasoftware () gmail ! com>
Date:       2014-12-28 16:31:37
Message-ID: CAGUMyaS_Q9AETvh4B_+Ex-03SFdNCrxc0bYz6HX53OCUSNaGdA () mail ! gmail ! com
[Download RAW message or body]

Thanks!

I'm about to push the fix with this commit message:

8067364: Printing to Postscript doesn't support dieresis
Summary: Fix regression caused by fix for 8023990
Reviewed-by: bae, prr
Contributed-by: neugens@redhat.com, philip.race@oracle.com

I added the Contributed-by tag because I only contributed the test and
did some initial assessment, the actual patch was from Phil, not sure
if this is correct though, doesn't seem to be the intended use for
this tag (We had a discussion on this sort of things some time ago,
but I can't find the mail exchanges in the archives).

Cheers,
Mario

2014-12-22 0:35 GMT+01:00 Andrew Brygin <andrew.brygin@oracle.com>:
> Hello Mario,
>
>  the change looks fine to me.
>
> Thanks,
> Andrew
>
> ----- Original Message -----
> From: neugens@redhat.com
> To: philip.race@oracle.com
> Cc: 2d-dev@openjdk.java.net
> Sent: Friday, December 19, 2014 7:34:06 PM GMT +04:00 Abu Dhabi / Muscat
> Subject: Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis
>
> On Fri, 2014-12-12 at 11:06 -0800, Phil Race wrote:
>> Correct. jtreg doesn't like System.exit() but I also understand that shell
>> tests are now highly frowned upon.
>> So either
>> 1) Run using "othervm" where calling System.exit() should be fine - I
>> think !?
>> 2) Don't worry about it, assuming jtreg can clean up if needed. If it can't
>> halt the test threads then that seems to be a different problem that I'd
>> expect occurs in many tests.
>
> Looks like jtreg knows what to do. I'm still running in othervm but it
> looks like the tests are now behaving correctly:
>
> http://cr.openjdk.java.net/~neugens/8067364/webrev.01/
>
> I still need a second reviewer then I can proceed.
>
> Cheers,
> Mario
>



-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens
Proud GNU Classpath developer: http://www.classpath.org/
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/
[prev in list] [next in list] [prev in thread] [next in thread]