[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: 8065373 [macosx] jdk8, jdk7u60 Regression in Graphics2D dra
From: Andrew Brygin <andrew.brygin () oracle ! com>
Date: 2014-12-16 15:31:26
Message-ID: 5490504E.7000207 () oracle ! com
[Download RAW message or body]
Hello Sergey,
the change looks fine to me.
Thanks,
Andrew.
On 12/12/2014 12:57 AM, Sergey Bylokhov wrote:
> Hi, Phil.
> ----- philip.race@oracle.com wrote:
> >
> > Consistent treatment of concatenating sInverseTx seems right although
> > I am not sure of the overall picture here.
> >
> > Quartz uses "y increases upwards"
> >
> https://developer.apple.com/library/ios/documentation/GraphicsImaging/Conceptual/dra \
> wingwithquartz2d/dq_overview/dq_overview.html#//apple_ref/doc/uid/TP30001066-CH202-CJBBAEEC
>
> >
> > 2d uses "y increases downwards"
> > https://docs.oracle.com/javase/tutorial/2d/overview/coordinate.html
> >
> > It seems like this transform
> > static CGAffineTransform sInverseTX = { 1, 0, 0, -1, 0, 0 };
> >
> > might have been to compensate to adjust into the quartz coordinate
> system
>
> Right.
>
> > But I'd expect to see flipped text, not just incorrectly rotated
> text, if
> > this were the problem, so I am far from sure about all of this
>
> The problem also in the fact that fFontTx is incorrectly translated,
> it is set in SG2D.checkFontInfo(). And CTextPipeline use this
> translation instead of fontinfo.originX/Y.
>
> >
> > -phil.
> >
> > *
> > *On 12/10/14 5:31 AM, Sergey Bylokhov wrote:
> >
>
> Hello.
> > Please review the fix for jdk 9/8u40.
> > Device transformation "fDevTx ", which was added in [1] and
> fFontTx contains different "directions".
> > Both of them are used in calculation of advances, because of
> that in some cases we get incorrect/opposite text rotation.
> > Note that I am not sure that fFontTx itself is correct, because
> it is used in printing, which is broken also since a beginning.
> But for now I simply change the newly added fDevTx to fix a
> regression.
> >
> > [1] http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a8b9df782017
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8065373
> > Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8065373/webrev.00
> >
> >
>
>
> >
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hello Sergey,<br>
<br>
the change looks fine to me.<br>
<br>
Thanks,<br>
Andrew.<br>
<br>
<br>
On 12/12/2014 12:57 AM, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:21417566-8566-42ed-b9b8-b1ae872cd755@default"
type="cite">
<style type="text/css">p { margin: 0; }</style>
<div style="font-family: Times New Roman; font-size: 12pt; color:
#000000">Hi, Phil.<br>
----- <a class="moz-txt-link-abbreviated" \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a> wrote: <br>
>
<div>
<div class="moz-cite-prefix">> Consistent treatment of
concatenating sInverseTx seems right although<br>
> I am not sure of the overall picture here.<br>
> <br>
> Quartz uses "y increases upwards"<br>
> <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://developer.apple.com/library/ios/documentation/GraphicsImaging/Conceptual \
/drawingwithquartz2d/dq_overview/dq_overview.html#//apple_ref/doc/uid/TP30001066-CH202-CJBBAEEC"
target="_blank">https://developer.apple.com/library/ios/documentation/GraphicsImagin \
g/Conceptual/drawingwithquartz2d/dq_overview/dq_overview.html#//apple_ref/doc/uid/TP30001066-CH202-CJBBAEEC</a><br>
> <br>
> 2d uses "y increases downwards"<br>
> <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://docs.oracle.com/javase/tutorial/2d/overview/coordinate.html"
target="_blank">https://docs.oracle.com/javase/tutorial/2d/overview/coordinate.html</a><br>
> <br>
> It seems like this transform <br>
> static CGAffineTransform sInverseTX = { 1, 0, 0, -1, 0,
0 };<br>
> <br>
> might have been to compensate to adjust into the quartz
coordinate system<br>
<br>
Right.<br>
<br>
> But I'd expect to see flipped text, not just
incorrectly rotated text, if<br>
> this were the problem, so I am far from sure about all
of this<br>
<br>
The problem also in the fact that fFontTx is incorrectly
translated, it is set in SG2D.checkFontInfo(). And
CTextPipeline use this translation instead of
fontinfo.originX/Y.<br>
<br>
> <br>
> -phil.<br>
> <br>
> <b><br>
> </b>On 12/10/14 5:31 AM, Sergey Bylokhov wrote:<br>
> </div>
<blockquote cite="mid:54884B3E.6060801@oracle.com">Hello. <br>
> Please review the fix for jdk 9/8u40. <br>
> Device transformation "fDevTx ", which was added in [1]
and fFontTx contains different "directions". <br>
> Both of them are used in calculation of advances,
because of that in some cases we get incorrect/opposite text
rotation. <br>
> Note that I am not sure that fFontTx itself is correct,
because it is used in printing, which is broken also since a
beginning. But for now I simply change the newly added
fDevTx to fix a regression. <br>
> <br>
> [1] <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a8b9df782017"
target="_blank">http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a8b9df782017</a>
<br>
> <br>
> Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8065373"
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8065373</a>
<br>
> Webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8065373/webrev.00"
target="_blank">http://cr.openjdk.java.net/~serb/8065373/webrev.00</a>
<br>
> <br>
> </blockquote>
<br>
> </div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic