[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] freetypescaler fix for fonts that start with a control point
From:       Doug Felt <dougfelt () google ! com>
Date:       2014-09-11 1:15:28
Message-ID: CAK9MbuKZ124WnAEL=64hHNz_SYbtVu0chvCrw5qhO78KXfNTaw () mail ! gmail ! com
[Download RAW message or body]

Hi Phil. I looked at it and it seems fine. Like you I assume using
FT_Outline_Decompose is a win over iterating through the control points by
hand.


On Wed, Sep 10, 2014 at 2:51 PM, Phil Race <philip.race@oracle.com> wrote:

> Yes, its a client-libs thing. We've always (10 years+) asked for two
> reviewers
> except for trivial reviews. I don't think I can count the number of times
> one reviewer has spotted something the other one missed. Maybe Doug ?
>
> -phil.
>
> On 9/10/2014 2:41 PM, Martin Buchholz wrote:
>
>
>>
>> On Wed, Sep 10, 2014 at 2:38 PM, Phil Race <philip.race@oracle.com
>> <mailto:philip.race@oracle.com>> wrote:
>>
>>     On 9/10/2014 2:31 PM, Martin Buchholz wrote:
>>
>>         I have tried to cross all the t's left here.  I took your
>>         suggestion and minimized the test greatly.  I've taken
>>         ownership of the bug and it's now marked noreg-hard.
>>
>>         I'm inclined to check in the test case as is, even though it's
>>         manual.  But I leave that to you, the 2d maintainers.
>>
>>         The only testing I've done is to run the one manual test.
>>  Hope that's OK.
>>
>>         OK to commit this fix?
>>
>>
>>     Do we yet have a 2nd reviewer on the change ?
>>
>>
>> Is that a client-libs-thing?  In core-libs, one reviewer is enough for
>> jdk9.
>>
>> This patch has been in use at Google for a while.
>>
>>     Other than that its fine by me.
>>
>>
>


-- 

Doug Felt | Software Engineer | dougfelt@google.com
<https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=dougfelt@google.com> |
 1-650-253-2089

[Attachment #3 (text/html)]

<div dir="ltr">Hi Phil. I looked at it and it seems fine. Like you I assume using \
FT_Outline_Decompose is a win over iterating through the control points by \
hand.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 10, \
2014 at 2:51 PM, Phil Race <span dir="ltr">&lt;<a \
href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Yes, its a client-libs thing. We&#39;ve always (10 years+) \
asked for two reviewers<br> except for trivial reviews. I don&#39;t think I can count \
the number of times<br> one reviewer has spotted something the other one missed. \
Maybe Doug ?<br> <br>
-phil.<br>
<br>
On 9/10/2014 2:41 PM, Martin Buchholz wrote:<div class="HOEnZb"><div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
<br>
On Wed, Sep 10, 2014 at 2:38 PM, Phil Race &lt;<a \
href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a> \
&lt;mailto:<a href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a><u></u>&gt;&gt; wrote:<br> <br>
      On 9/10/2014 2:31 PM, Martin Buchholz wrote:<br>
<br>
            I have tried to cross all the t&#39;s left here.   I took your<br>
            suggestion and minimized the test greatly.   I&#39;ve taken<br>
            ownership of the bug and it&#39;s now marked noreg-hard.<br>
<br>
            I&#39;m inclined to check in the test case as is, even though \
it&#39;s<br>  manual.   But I leave that to you, the 2d maintainers.<br>
<br>
            The only testing I&#39;ve done is to run the one manual test.             \
Hope that&#39;s OK.<br> <br>
            OK to commit this fix?<br>
<br>
<br>
      Do we yet have a 2nd reviewer on the change ?<br>
<br>
<br>
Is that a client-libs-thing?   In core-libs, one reviewer is enough for jdk9.<br>
<br>
This patch has been in use at Google for a while.<br>
<br>
      Other than that its fine by me.<br>
<br>
</blockquote>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:&#39;Times \
New Roman&#39;"><tbody><tr \
style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap \
style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Doug \
Felt  |</td><td nowrap \
style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> \
Software Engineer |</td><td nowrap \
style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px">  \
<a href="https://mail.google.com/mail/?view=cm&amp;fs=1&amp;tf=1&amp;to=dougfelt@google.com" \
target="_blank">dougfelt@google.com</a>  |</td><td nowrap \
style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> \
1-650-253-2089</td></tr></tbody></table><br><span \
style="color:rgb(0,0,0);font-family:&#39;Times New \
Roman&#39;;font-size:medium"></span></div> </div>



[prev in list] [next in list] [prev in thread] [next in thread]