[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] Review request for JDK-8054638 xrender: text drawn after setColor(Color.white) 
From:       Andrew Brygin <andrew.brygin () oracle ! com>
Date:       2014-08-26 23:28:58
Message-ID: 53FD183A.8040508 () oracle ! com
[Download RAW message or body]

Hello Clemens,

  the fix and the test look fine to me. The test probably can be 
simplified a bit
  with using getSnapshot() method of VolatileImage class, but it does 
not matter
  much here.

Thanks,
Andrew

On 8/26/2014 11:35 PM, Phil Race wrote:
> Andrew or Jennifer : can you add your review 2c
>
> The 8u backport is worth doing as we have had 2 independent reports
> of this. That backport needs to be approved by the 8u gatekeeper.
> I can take care of that once this is in 9.
>
> -phil.
>
> On 8/26/14 12:25 PM, Clemens Eisserer wrote:
>>> It needs the GPL license (copied from another test to get the right 
>>> one)
>>> and there's one typo :  wether -> whether
>> Header added, thanks for finding the typo:
>> http://cr.openjdk.java.net/~ceisserer/8054638/WhiteTextColorTest.java
>>
>>> Otherwise looks fine.
>> In case no other issues pop up and a second reviewer can be found,
>> please commit.
>>
>> The patch was written against OpenJDK9, however should apply as-is
>> against OpenJDK8.
>> Is there any special backport procedure required or will the fix be
>> applied against both versions at once - as the bug was reported
>> against 8?
>>
>> Thanks, Clemens
>

[prev in list] [next in list] [prev in thread] [next in thread]