[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request: 8055326 Fix typos in client-related packages
From:       Phil Race <philip.race () oracle ! com>
Date:       2014-08-21 18:04:43
Message-ID: 53F634BB.7000905 () oracle ! com
[Download RAW message or body]

Was the additional spce on the 2nd line intended here ?

--- old/src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java	2014-08-21 \
                20:50:04.859532400 +0400
+++ new/src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java	2014-08-21 \
20:50:04.663521200 +0400 @@ -166,8 +166,8 @@
                      retComp = \
cont.getFocusTraversalPolicy().getDefaultComponent(cont);  
                      if (retComp != null && \
                log.isLoggable(PlatformLogger.Level.FINE)) {
-                        log.fine("### Transfered focus down-cycle to " + retComp +
-                                 " in the focus cycle root " + cont);
+                        log.fine("### Transferred focus down-cycle to " + retComp +
+                                " in the focus cycle root " + cont);


And I don't see what was so wrong with this, perhaps because I wrote it :-)

-         * so that when the Font2D is GC'd it can also remove the file.
+         * so that when the Font2D is GC'ed it can also remove the file.


Other than that, looks good.
Some fun new words in there. I particularly liked utilitized and unclude.

-phil.

On 8/21/2014 10:38 AM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk 9.
> The fix was contributed by  pavel.rappo@oracle.com
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8055326
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8055326/webrev.00
> 


[prev in list] [next in list] [prev in thread] [next in thread]