[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8048583: CustomMediaSizeName class matching to standard media is too loose
From:       Jennifer Godinez <jennifer.godinez () oracle ! com>
Date:       2014-07-14 18:05:54
Message-ID: 53C41C02.2030106 () oracle ! com
[Download RAW message or body]

Looks good.

Jennifer
On 7/11/2014 11:24 AM, Phil Race wrote:
>
> http://cr.openjdk.java.net/~prr/8048583.1/
> updated version to fix the incorrect usage of w and h instead of dw 
> and dh
> spotted by Andrew.
>
> -phil.
>
> On 06/27/2014 01:40 PM, Phil Race wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8048583
>> Fix : http://cr.openjdk.java.net/~prr//
>>
>> As described in the bug the basic problem is that we associate
>> a printer defined media with an inappropriate "standard" media.
>>
>> If there's no standard media that matches to within a fraction,
>> don't return one.
>>
>> It is difficult to provide a direct or useful test for this as
>> knowing if its right requires having a  CUPS printer
>> which triggers the code and even then this isn't exposed directly.
>> It bubbles up as somewhat odd margins for the page ..
>>
>> But hopefully it should be apparent that saying the paper
>> size matches to a different size is a problem.
>>
>> Returning null from CustomMediSizeName.getStandardMedia()
>> is something that already is possible and I did double-check all
>> the callers seem to be looking for the possibility of null.
>>
>> -phil.
>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]