[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] <Swing Dev> RFR : 8049893 Replace uses of 'new Integer()' with appropriate alte
From:       Andrej Golovnin <andrej.golovnin () gmail ! com>
Date:       2014-07-11 9:00:10
Message-ID: CAM6ZMz8ThjEncPXQrxXMX764zXFgS4S-KncbZkPD9L7LxKN+Bw () mail ! gmail ! com
[Download RAW message or body]

Hi Petr,

BasicLookAndFeel - making "shared Integers" and "shared longs" is pointless
> after your fix. Please inline.
>

It's not pointless.

 458         Integer fiveHundred = 500;
 459
 460         // *** Shared Longs
 461         Long oneThousand = 1000L;

500 and 1000L are outside of the range [-127, 128]. Therefore they won't be
cached.

But this one:

676         Integer four = 4;

can be indeed inlined.

Best regards,
Andrej Golovnin



>
> With best regards. Petr.
>
> On Jul 11, 2014, at 5:36 AM, Otávio Gonçalves de Santana <
> otaviopolianasantana@gmail.com> wrote:
>
> https://bugs.openjdk.java.net/browse/JDK-8049893
> http://cr.openjdk.java.net/~prr/8049893/
>
> --
> Cheers!.
>
> Otávio Gonçalves de Santana
>
> blog:     http://otaviosantana.blogspot.com.br/
> twitter: http://twitter.com/otaviojava
> site:     *http://about.me/otaviojava <http://about.me/otaviojava>*
> 55 (11) 98255-3513
>
>
>

[Attachment #3 (text/html)]

<div dir="ltr">Hi Petr,<div><br></div><div class="gmail_extra"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
 <div style="word-wrap:break-word"><div>BasicLookAndFeel - making "shared Integers" \
and "shared longs" is pointless after your fix. Please \
inline.</div></div></blockquote><div><br></div><div>It&#39;s not \
pointless.</div><div> <br></div><div><div>  458             Integer fiveHundred = \
500;</div><div>  459  </div><div>  460             // *** Shared Longs</div><div>  \
461             Long oneThousand = 1000L;</div></div><div><br></div><div>500 and \
1000L are outside of the range [-127, 128]. Therefore they won&#39;t be cached.</div> \
<div><br></div><div>But this one:</div><div><br></div><div>676             Integer \
four = 4;<br></div><div><br></div><div>can be indeed \
inlined.</div><div><br></div><div>Best regards,</div><div>Andrej \
Golovnin</div><div><br></div> <div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
style="word-wrap:break-word"><div><br></div> <div>With best regards. \
Petr.</div><div><div class="h5"><div><br></div><div><div><blockquote \
type="cite"><div>On Jul 11, 2014, at 5:36 AM, Otávio Gonçalves de Santana &lt;<a \
href="mailto:otaviopolianasantana@gmail.com" \
target="_blank">otaviopolianasantana@gmail.com</a>&gt; wrote:</div> <br><div><div \
dir="ltr"><a href="https://bugs.openjdk.java.net/browse/JDK-8049893" \
style="font-family:arial,sans-serif;font-size:13px" \
target="_blank">https://bugs.openjdk.java.net/<u></u>browse/JDK-8049893</a><br \
style="font-family:arial,sans-serif;font-size:13px">


<a href="http://cr.openjdk.java.net/~prr/8049893/" \
style="font-family:arial,sans-serif;font-size:13px" \
target="_blank">http://cr.openjdk.java.net/~<u></u>prr/8049893/</a><br \
clear="all"><div><br></div>-- <br><div dir="ltr">


Cheers!.<br><br>Otávio Gonçalves de Santana<div><div \
style="text-align:center"><br><div style="text-align:left"><font face="Tahoma">blog:  \
</font><a href="http://otaviosantana.blogspot.com.br/" style="text-align:center" \
target="_blank">http://otaviosantana.blogspot.com.br/</a></div>


<div style="text-align:left">twitter:  <a href="http://twitter.com/otaviojava" \
target="_blank">http://twitter.com/otaviojava</a></div><div \
style="text-align:left">site:        <span style="text-align:center"><font \
color="#0000ee"><u><a href="http://about.me/otaviojava" \
target="_blank">http://about.me/otaviojava</a></u></font></span></div>


<div style="text-align:left">55 (11) 98255-3513</div><div \
style="text-align:-webkit-auto"><br></div></div></div></div> </div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>




[prev in list] [next in list] [prev in thread] [next in thread]