[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface->sw blit
From:       Phil Race <philip.race () oracle ! com>
Date:       2014-06-11 3:41:42
Message-ID: 5397CFF6.3080609 () oracle ! com
[Download RAW message or body]

Looks reasonable to me ..

-phil.

On 6/5/14 4:40 AM, Sergey Bylokhov wrote:
> Hi, Andrew.
> CR filed https://bugs.openjdk.java.net/browse/JDK-8044788
> testcase updated: http://cr.openjdk.java.net/~serb/8041644/webrev.01
>
> On 03.06.2014 18:02, Andrew Brygin wrote:
>> Hello Sergey,
>>
>>  the fix for ogl looks fine to me.
>>
>>  Could you please update the test, and submit a separate bug against 
>> d3d?
>>
>> Thanks,
>> Andrew
>>
>> On 5/20/2014 9:31 PM, Sergey Bylokhov wrote:
>>> On 5/20/14 9:17 PM, Phil Race wrote:
>>>> On 5/20/2014 10:03 AM, Sergey Bylokhov wrote:
>>>>> On 5/20/14 8:52 PM, Phil Race wrote:
>>>>>> So my first question here was. So what does D3D do ? We should 
>>>>>> just copy that code.
>>>>> D3D doesn't work as well.
>>>>>> Then I read the bug report and it says D3D has the same bug
>>>>>> I don't get why you'd fix it for OGL but not for D3D which seems 
>>>>>> like the
>>>>>> way more important case.
>>>>> OGL is important too, because it is default pipeline on osx. I 
>>>>> plan to fix D3D case later.
>>>>
>>>> And D3D is the default pipeline on Windows !  I submit that there 
>>>> are (many) more people
>>>> world-wide using that than OS X.
>>> I agree but right now I have no tested version of the fix for d3d.
>>>>
>>>>> Actually I am not familiar with d3d code and right now I focused 
>>>>> on hidpi support in SwingNode on OSX.
>>>>>> So when you check this in we'll just get one more failing 
>>>>>> regression test.
>>>>> Yes. It will be bound to the separate CR.
>>>>
>>>> At a minimum the test should only run on OS X or should specify 
>>>> -Dsun.java2d.d3d=false
>>>> until Windows is resolved.
>>> Ok. I will add this option to the test before the push.
>>>>
>>>> But I really think this should all be checked in as one fix.
>>>>
>>>>
>>>> -phil.
>>>>
>>>>>>
>>>>>> -phil.
>>>>>>
>>>>>>
>>>>>> On 5/20/2014 9:42 AM, Sergey Bylokhov wrote:
>>>>>>> Hello.
>>>>>>> Please review the fix for jdk 9, which is also targeted for jdk 
>>>>>>> 8u20.
>>>>>>> Description:
>>>>>>>     Our implementation of opengl surface-> sw blit does not take 
>>>>>>> into account the clipped area.
>>>>>>> Suggested fix:
>>>>>>>    I intersect a clip and a coordinates of destination, and if 
>>>>>>> the resulted region is rectangle I use the usual blit, but if 
>>>>>>> the region is complex I use intermediate buffer(like 
>>>>>>> OGLAnyCompositeBlit.Blit() or OGLGeneralBlit.Blit()).
>>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8041644
>>>>>>> Webrev can be found at: 
>>>>>>> http://cr.openjdk.java.net/~serb/8041644/webrev.00
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]