[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2014-05-14 14:11:01
Message-ID: 53737975.5070109 () oracle ! com
[Download RAW message or body]

Hi, Andrew.
The fix looks good.

On 5/9/14 2:27 AM, Andrew Brygin wrote:
> Hello Phil,
>
>  I have corrected both occurrences of the typo:
>
> http://cr.openjdk.java.net/~bae/6945174/9/webrev.01/
>
> Thanks,
> Andrew
>
> On 5/9/2014 2:04 AM, Phil Race wrote:
>> Looks OK but please fix the typo in the exception string  .. lenght 
>> -> length
>>
>> -phil.
>>
>> On 5/8/14 11:43 AM, Andrew Brygin wrote:
>>> Hello,
>>>
>>> could you please review a fix for CR 6945174?
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6945174
>>> Webrev: http://cr.openjdk.java.net/~bae/6945174/9/webrev.00/
>>>
>>> PNG image reader validates the length of chunk's data
>>> when reads image metadata. However, if metadata is ignored,
>>> the length  is used to skip data in the stream without
>>> any validation.
>>>
>>> Suggested fix just introduces a validation of the chunk
>>> data length for the case of ignored metadata in a similar
>>> way as it is done for the case of metadata processing.
>>>
>>> Supplied regression test demonstrates the problem.
>>>
>>> Please take a look.
>>>
>>> Thanks,
>>> Andrew.
>>
>


-- 
Best regards, Sergey.

[prev in list] [next in list] [prev in thread] [next in thread]