[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio
From:       Phil Race <philip.race () oracle ! com>
Date:       2014-02-21 21:58:38
Message-ID: 5307CC7C.9090408 () oracle ! com
[Download RAW message or body]

Ditto .

-phil.

On 2/20/2014 11:48 PM, Andrew Brygin wrote:
> Hello Henry,
> 
> the fix looks fine to me.
> 
> Thanks,
> Andrew
> 
> On 2/21/2014 1:01 AM, Henry Jen wrote:
> > Hi,
> > 
> > Please review the latest update, I think this should address the 
> > issues raised,
> > 
> > http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/
> > 
> > - revert the clone method changes so that return type remains Object
> > - break long lines
> > - fix fallthrough warnings as Andrew suggested.
> > 
> > Cheers,
> > Henry
> > 
> > 
> > On 02/20/2014 10:09 AM, Phil Race wrote:
> > > On 2/20/2014 12:05 AM, Henry Jen wrote:
> > > > On 02/19/2014 02:59 PM, Henry Jen wrote:
> > > > > On 02/19/2014 01:46 PM, Phil Race wrote:
> > > > > > 
> > > > > > W.r.t the following change ...
> > > > > > 
> > > > > > http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html \
> > > > > >  
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 145     class Htable implements Cloneable {
> > > > > > 
> > > > > > ...
> > > > > > <208          protected Object clone() {
> > > > > > 
> > > > > > > 208         protected Htable clone()
> > > > > > 
> > > > > > ---------
> > > > > > 
> > > > > > exactly what warning is this suppressing ?
> > > > > 
> > > > > This eliminate "unchecked" cast warning when calling this method 
> > > > > to get
> > > > > an instance with correct class type.
> > > > > 
> > > > 
> > > > That's not exactly correct, it just eliminate the need to cast, not
> > > > warning.
> > > > 
> > > > Would you advice to revert them or keep it?
> > > 
> > > In that case, I'd suggest to revert them
> > > 
> > > -phil.
> 


[prev in list] [next in list] [prev in thread] [next in thread]