[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio
From:       Phil Race <philip.race () oracle ! com>
Date:       2014-02-20 18:09:30
Message-ID: 530644DA.2040209 () oracle ! com
[Download RAW message or body]

On 2/20/2014 12:05 AM, Henry Jen wrote:
> On 02/19/2014 02:59 PM, Henry Jen wrote:
> > On 02/19/2014 01:46 PM, Phil Race wrote:
> > > 
> > > W.r.t the following change ...
> > > 
> > > http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html \
> > >  
> > > 
> > > 
> > > 
> > > 
> > > 145     class Htable implements Cloneable {
> > > 
> > > ...
> > > <208          protected Object clone() {
> > > 
> > > > 208         protected Htable clone()
> > > 
> > > ---------
> > > 
> > > exactly what warning is this suppressing ?
> > 
> > This eliminate "unchecked" cast warning when calling this method to get
> > an instance with correct class type.
> > 
> 
> That's not exactly correct, it just eliminate the need to cast, not 
> warning.
> 
> Would you advice to revert them or keep it?

In that case, I'd suggest to revert them

-phil.


[prev in list] [next in list] [prev in thread] [next in thread]