'Re: [OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from
From:       Andrew Brygin <andrew.brygin () oracle ! com>
Date:       2013-12-05 8:18:01
Message-ID: 52A036B9.9060603 () oracle ! com
[Download RAW message or body]

Looks fine.

Thanks,
Andrew

On 11/22/2013 7:24 PM, anton nashatyrev wrote:
> Hello,
>
>     this is a duplicate request:
>
>     could you please review the following fix:
>
> fix: http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00 
> <http://cr.openjdk.java.net/%7Ealitvinov/8023990/webrev.00>
> bug: https://bugs.openjdk.java.net/browse/JDK-8023990
>
>      When the FcFontConfiguration was added for using fontconfig on a 
> set of Linux platforms (as well as OpenSolaris) (the corresponding rfe 
> is here <https://bugs.openjdk.java.net/browse/JDK-8023990>), the 
> implementation of the method FcFontConfiguration.getFontDescriptors() 
> returned just an empty array. This functionality is actually not used 
> by anyone except of the PSPrinterJob which tries to find out whether 
> the string could be represented using PS embedded font. If this 
> procedure fails then the PSPrinterJob falls back to glyphs outline 
> printing. As I understand this normally happened for strings 
> containing non-ASCII characters. For ASCII strings PSPrinterJob 
> usually selected the PS embedded font. With the addition of 
> FcFontConfiguration even ASCII strings output starts to fall back to 
> outlines.
>
>     The fix is some basic implementation of the getFontDescriptors() 
> functionality. The returned FontDecriptors don't contain missing glyph 
> information. Though it might be queried from the fontconfig library 
> (with some additional effort) this doesn't change the behavior of 
> PSPrinterJob, since all the fonts has the ISO 10646 encoding (UTF-8), 
> and the PSPrinterJob will still be falling back to outlines for any 
> non-ASCII strings.
>
> Thanks!
> Anton.


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Looks fine.<br>
      <br>
      Thanks,<br>
      Andrew<br>
      <br>
      On 11/22/2013 7:24 PM, anton nashatyrev wrote:<br>
    </div>
    <blockquote cite="mid:528F773F.10104@oracle.com" type="cite">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      Hello, <br>
       <br>
          this is a duplicate request: <br>
      <br>
          could you please review the following fix:<br>
      <br>
      fix: <a moz-do-not-send="true"
        href="http://cr.openjdk.java.net/%7Ealitvinov/8023990/webrev.00">http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00</a><br>
  bug: <a moz-do-not-send="true"
        href="https://bugs.openjdk.java.net/browse/JDK-8023990">https://bugs.openjdk.java.net/browse/JDK-8023990</a><br>
  <br>
           When the FcFontConfiguration was added for using fontconfig
      on a set of Linux platforms (as well as OpenSolaris) (the
      corresponding rfe is <a moz-do-not-send="true"
        href="https://bugs.openjdk.java.net/browse/JDK-8023990">here</a>),


      the implementation of the method
      FcFontConfiguration.getFontDescriptors() returned just an empty
      array. This functionality is actually not used by anyone except of
      the PSPrinterJob which tries to find out whether the string could
      be represented using PS embedded font. If this procedure fails
      then the PSPrinterJob falls back to glyphs outline printing. As I
      understand this normally happened for strings containing non-ASCII
      characters. For ASCII strings PSPrinterJob usually selected the PS
      embedded font. With the addition of FcFontConfiguration even ASCII
      strings output starts to fall back to outlines.<br>
      <br>
          The fix is some basic implementation of the
      getFontDescriptors() functionality. The returned FontDecriptors
      don't contain missing glyph information. Though it might be
      queried from the fontconfig library (with some additional effort)
      this doesn't change the behavior of PSPrinterJob, since all the
      fonts has the ISO 10646 encoding (UTF-8), and the PSPrinterJob
      will still be falling back to outlines for any non-ASCII strings.<br>
      <br>
      Thanks! <br>
      Anton. <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic