[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <2D Dev> [8] Review Request: JDK-8025235 [javadoc] fix some errors in 2D
From: Dmitry Ginzburg <dmitry.x.ginzburg () oracle ! com>
Date: 2013-10-30 16:38:44
Message-ID: 52713614.1050408 () oracle ! com
[Download RAW message or body]
Hi guys
I haven't got any review from you on this issue. Can you please review it?
For some issue, my e-mail have changed to dmitry.x.ginzburg@oracle.com
Thanks, Dmitry
*
Dmitry Ginzburg* dmitry.ginzburg at oracle.com \
<mailto:2d-dev%40openjdk.java.net?Subject=%5BOpenJDK%202D-Dev%5D%20%3C2D%20Dev%3E%20%5 \
B8%5D%20Review%20Request%3A%20JDK-8025235%0A%20%5Bjavadoc%5D%20fix%20some%20errors%20in%202D&In-Reply-To=524EE4DB.8010602%40oracle.com>
/Tue Oct 15 06:02:58 PDT 2013/
See new webrev:http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.02/ \
<http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/> \
<http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/> Some changes are deleted, \
because they're fixed by someone but me
04.10.2013 19:55, Phil Race wrote:
> / Hi,
/>/
/>/ A few places you used {@code that is not code} : ie PageAttributes for
/>/ the &
/>/ and Line2D.Float() constructor and in MultipleMaster are the ones I
/>/ spotted
/>/ probably aren't appropriate as they aren't code, and the {@code ..}
/>/ will use
/>/ a fixed width font. So one char will be in a different font.
/>/ As I suggested in PageAttributes just use "and", there's no reason it
/>/ has to
/>/ be an ampersand.
/>/
/>/ -phil.
/>/
/>/ On 10/4/2013 5:59 AM, Dmitry Ginzburg wrote:
/>>/ Hi, Phil
/>>/
/>>/ I renewed webrev against your issues:
/>>/ http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.01/ \
<http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/> />>/ \
<http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/> />>/
/>>/ Thanks,
/>>/ -Dmitry
/>>/
/>>/ 03.10.2013 08:41, Phil Race wrote:
/>>>/ 1. This webrev is not against the 2D forest. Please re-generate
/>>>/ against 2D.
/>>>/
/>>>/ 2.
/>>>/ /local/work/jdk8/jdk8/jdk/src/share/classes/java/awt/GraphicsConfiguration.java:84:
/>>>/ error: malformed HTML
/>>>/ When you have < & > chars in code the preferred solution uses
/>>>/ {@code .. } like this :
/>>>/ http://cr.openjdk.java.net/~prr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html \
<http://cr.openjdk.java.net/%7Eprr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html> \
/>>>/
/>>>/
/>>>/ 3. Same as above for GraphicsDevice
/>>>/
/>>>/ 4. Same as above for MediaTracker (it'll fix all 3 issues)
/>>>/
/>>>/ 5. I think we should change all 12 or so of these to the word "and"
/>>>/
/>>>/ 6. Rectangle : same as 2
/>>>/
/>>>/ 7. LineBreakMeasurer : same again in all locations
/>>>/
/>>>/ 8. {@code .. } should fix this too
/>>>/
/>>>/ 9. LIne2D 626: {@code true} would be better here too
/>>>/
/>>>/ 10. PrinterJob: {@code .. } again
/>>>/
/>>>/ Make sure you verify by re-running doclint on the fixed repo.
/>>>/
/>>>/ That's all.
/>>>/
/>>>/ -phil.
/>>>/
/>>>/ On 9/26/13 7:21 AM, Dmitry Ginzburg wrote:
/>>>>/ Hello, 2D Team.
/>>>>/
/>>>>/ Please review the fix for the following issue:
/>>>>/ https://bugs.openjdk.java.net/browse/JDK-8025235
/>>>>/ The fix is available at:
/>>>>/ http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.00/ \
<http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.00/> />>>>/
/>>>>/ This is the fix for javadoc errors, on which doclint was showing
/>>>>/ some issues.
/>>>>/
/>>>>/ The patch contains only simple markup fixes; no changes/fixes in
/>>>>/ documentation text; the specification itself wasn't changed.
/>>>>/
/>>>>/ Thanks,
/>>>>/ -Dmitry
/>>>/
/>>/
/>>/
/>>/ --
/>>/ Dmitry Ginzburg, FXSQE team member
/>/
/
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; \
text-align: start; text-indent: 0px; text-transform: none; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre-wrap;"><meta \
http-equiv="content-type" content="text/html; charset=UTF-8"><span style="color: \
rgb(0, 0, 0); font-family: 'Times New Roman'; font-size: medium; font-style: normal; \
font-variant: normal; letter-spacing: normal; line-height: normal; orphans: auto; \
text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi guys
I haven't got any review from you on this issue. Can you please review it?
For some issue, my e-mail have changed to <a class="moz-txt-link-abbreviated" \
href="mailto:dmitry.x.ginzburg@oracle.com">dmitry.x.ginzburg@oracle.com</a>
Thanks, Dmitry
</span><b style="color: rgb(0, 0, 0); font-family: 'Times New Roman'; font-size: \
medium; font-style: normal; font-variant: normal; letter-spacing: normal; \
line-height: normal; orphans: auto; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;"> Dmitry Ginzburg</b><span style="color: rgb(0, 0, \
0); font-family: 'Times New Roman'; font-size: medium; font-style: normal; \
font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: \
normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
background-color: rgb(255, 255, 255); display: inline !important; float: none;"><span \
class="Apple-converted-space"> </span></span><a \
href="mailto:2d-dev%40openjdk.java.net?Subject=%5BOpenJDK%202D-Dev%5D%20%3C2D%20Dev%3E \
%20%5B8%5D%20Review%20Request%3A%20JDK-8025235%0A%20%5Bjavadoc%5D%20fix%20some%20errors%20in%202D&In-Reply-To=524EE4DB.8010602%40oracle.com" \
title="[OpenJDK 2D-Dev] <2D Dev> [8] Review Request: JDK-8025235 [javadoc] fix \
some errors in 2D" style="font-family: 'Times New Roman'; font-size: medium; \
font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: \
normal; li! ne-height:
normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: \
0px;">dmitry.ginzburg at oracle.com<span class="Apple-converted-space"> </span></a> \
<i style="color: rgb(0, 0, 0); font-family: 'Times New Roman'; font-size: medium; \
font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: \
normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: \
0px;">Tue Oct 15 06:02:58 PDT 2013</i>
See new webrev: <a href="http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/">http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.02/</a> \
<<a href="http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/">http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/</a>>
Some changes are deleted, because they're fixed by someone but me
04.10.2013 19:55, Phil Race wrote:
><i> Hi,
</i>><i>
</i>><i> A few places you used {@code that is not code} : ie PageAttributes for
</i>><i> the &
</i>><i> and Line2D.Float() constructor and in MultipleMaster are the ones I
</i>><i> spotted
</i>><i> probably aren't appropriate as they aren't code, and the {@code ..}
</i>><i> will use
</i>><i> a fixed width font. So one char will be in a different font.
</i>><i> As I suggested in PageAttributes just use "and", there's no reason it
</i>><i> has to
</i>><i> be an ampersand.
</i>><i>
</i>><i> -phil.
</i>><i>
</i>><i> On 10/4/2013 5:59 AM, Dmitry Ginzburg wrote:
</i>>><i> Hi, Phil
</i>>><i>
</i>>><i> I renewed webrev against your issues:
</i>>><i> <a href="http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/">http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.01/</a> \
</i>>><i> <<a \
href="http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/">http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/</a>>
</i>>><i>
</i>>><i> Thanks,
</i>>><i> -Dmitry
</i>>><i>
</i>>><i> 03.10.2013 08:41, Phil Race wrote:
</i>>>><i> 1. This webrev is not against the 2D forest. Please re-generate
</i>>>><i> against 2D.
</i>>>><i>
</i>>>><i> 2.
</i>>>><i> /local/work/jdk8/jdk8/jdk/src/share/classes/java/awt/GraphicsConfiguration.java:84: \
</i>>>><i> error: malformed HTML
</i>>>><i> When you have < & > chars in code the preferred \
solution uses </i>>>><i> {@code .. } like this :
</i>>>><i> <a \
href="http://cr.openjdk.java.net/%7Eprr/8022175/src/share/classes/javax/print/ServiceU \
I.java.sdiff.html">http://cr.openjdk.java.net/~prr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html</a> \
</i>>>><i>
</i>>>><i>
</i>>>><i> 3. Same as above for GraphicsDevice
</i>>>><i>
</i>>>><i> 4. Same as above for MediaTracker (it'll fix all 3 issues)
</i>>>><i>
</i>>>><i> 5. I think we should change all 12 or so of these to the word \
"and" </i>>>><i>
</i>>>><i> 6. Rectangle : same as 2
</i>>>><i>
</i>>>><i> 7. LineBreakMeasurer : same again in all locations
</i>>>><i>
</i>>>><i> 8. {@code .. } should fix this too
</i>>>><i>
</i>>>><i> 9. LIne2D 626: {@code true} would be better here too
</i>>>><i>
</i>>>><i> 10. PrinterJob: {@code .. } again
</i>>>><i>
</i>>>><i> Make sure you verify by re-running doclint on the fixed repo.
</i>>>><i>
</i>>>><i> That's all.
</i>>>><i>
</i>>>><i> -phil.
</i>>>><i>
</i>>>><i> On 9/26/13 7:21 AM, Dmitry Ginzburg wrote:
</i>>>>><i> Hello, 2D Team.
</i>>>>><i>
</i>>>>><i> Please review the fix for the following issue:
</i>>>>><i> <a \
href="https://bugs.openjdk.java.net/browse/JDK-8025235">https://bugs.openjdk.java.net/browse/JDK-8025235</a>
</i>>>>><i> The fix is available at:
</i>>>>><i> <a \
href="http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.00/">http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.00/</a>
</i>>>>><i>
</i>>>>><i> This is the fix for javadoc errors, on which doclint was \
showing </i>>>>><i> some issues.
</i>>>>><i>
</i>>>>><i> The patch contains only simple markup fixes; no changes/fixes \
in </i>>>>><i> documentation text; the specification itself wasn't \
changed. </i>>>>><i>
</i>>>>><i> Thanks,
</i>>>>><i> -Dmitry
</i>>>><i>
</i>>><i>
</i>>><i>
</i>>><i> --
</i>>><i> Dmitry Ginzburg, FXSQE team member
</i>><i>
</i></pre>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic