[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] Resurrecting Lauren'ts work on speeding up Pisces
From: Laurent_Bourgès <bourges.laurent () gmail ! com>
Date: 2013-10-21 7:10:26
Message-ID: CAKjRUT69uEU5jCXPEWwVa+vOz2dLUFBFrj_4S9Tt4g9Ro4YmOw () mail ! gmail ! com
[Download RAW message or body]
Andrea,
I made some progress since webrev 4 (may 2013) but mainly stopped working
on it due to lack of time and there is apparently no way (no bug id, no
feedback) to integrate my efforts into JDK 8.
I can try soon to produce a new patch (5) including my last changes (close
to initial code, less changes) to make this work rebirth.
Maybe we could work together providing a better patch as you explained that
could be merged in JDK 8 or JDK 9 ...
Laurent
2013/10/19 Andrea Aime <andrea.aime@geo-solutions.it>
> Hi all,
> it's been a few months since my last mail.
> If you remember, I've tried participating to Laurent webrev discussions by
> providing
> a real world benchmark using GeoServer running the public OSGeo WMS
> shootout.
> If you want to read the last discussion on the topic, this was the thread:
> http://comments.gmane.org/gmane.comp.java.openjdk.2d.devel/3467
>
> Well, I'm back since I've managed to build a pure java PNG encoder that's
> significantly
> faster than both the JDK one, and the ImageIO native one (aka
> CLibPNGImageWriter),
> especially when run on OpenJDK, so I'm back trying to make the renderer
> itself faster
> for server side, headless workflows :-)
> (if you want more info on the PNG encoder work I'm at your disposal too,
> let's start a
> separate thread).
>
> Now, Laurent's work pretty much stopped at the fourth webrev, and I'm
> interested
> in trying to take over, provided there is a chance for the changes to be
> merged (either
> in JDK 8 or JDK 9).
>
> From my existing experience with open source projects I believe the
> patches can
> have a better chance of being merged by avoiding code style changes, and
> minimizing
> the changes to the bare minimum that provides the most significant
> speedup, and
> then make a choice on how the arrays should be cached (the CQL approach
> seems
> to be more promising) to further simplify the code.
>
> So, if I sign the OCA, can I look over Laurent's code and build a new
> webrev
> oriented to providing the minimum of changes to the existing code, possibly
> trying to avoid any change that would affect the ductus pipeline?
>
> Would this be a good approach to get the improvements merged?
> In general, what do you suggest would be the best course of action?
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div><div>Andrea,<br><br></div>I made some progress since webrev \
4 (may 2013) but mainly stopped working on it due to lack of time and there is \
apparently no way (no bug id, no feedback) to integrate my efforts into JDK 8. <br> \
<br></div>I can try soon to produce a new patch (5) including my last changes (close \
to initial code, less changes) to make this work rebirth.<br><br></div><div>Maybe we \
could work together providing a better patch as you explained that could be merged in \
JDK 8 or JDK 9 ...<br> </div><div><br></div>Laurent<br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">2013/10/19 Andrea Aime <span \
dir="ltr"><<a href="mailto:andrea.aime@geo-solutions.it" \
target="_blank">andrea.aime@geo-solutions.it</a>></span><br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi all,<div>it's been a few months since \
my last mail.</div><div>If you remember, I've tried participating to Laurent \
webrev discussions by providing</div> <div>a real world benchmark using GeoServer \
running the public OSGeo WMS shootout.</div> <div>If you want to read the last \
discussion on the topic, this was the thread:</div><div><a \
href="http://comments.gmane.org/gmane.comp.java.openjdk.2d.devel/3467" \
target="_blank">http://comments.gmane.org/gmane.comp.java.openjdk.2d.devel/3467</a></div>
<div><br></div><div>Well, I'm back since I've managed to build a pure java \
PNG encoder that's significantly</div><div>faster than both the JDK one, and the \
ImageIO native one (aka CLibPNGImageWriter),</div><div>
especially when run on OpenJDK, so I'm back trying to make the renderer itself \
faster</div><div>for server side, headless workflows :-)</div><div>(if you want more \
info on the PNG encoder work I'm at your disposal too, let's start a</div>
<div>separate thread).</div><div><br></div><div>Now, Laurent's work pretty much \
stopped at the fourth webrev, and I'm interested</div><div>in trying to take \
over, provided there is a chance for the changes to be merged (either</div>
<div>in JDK 8 or JDK 9).</div><div><br></div><div>From my existing experience with \
open source projects I believe the patches can</div><div>have a better chance of \
being merged by avoiding code style changes, and minimizing</div>
<div>the changes to the bare minimum that provides the most significant speedup, \
and</div><div>then make a choice on how the arrays should be cached (the CQL approach \
seems</div><div>to be more promising) to further simplify the code.</div>
<div><br></div><div>So, if I sign the OCA, can I look over Laurent's code and \
build a new webrev</div><div>oriented to providing the minimum of changes to the \
existing code, possibly</div><div>trying to avoid any change that would affect the \
ductus pipeline?</div>
<div><br></div><div>Would this be a good approach to get the improvements \
merged?</div><div>In general, what do you suggest would be the best course of \
action?</div><div><br></div><div>Cheers</div><div>Andrea</div><div><div>
<br></div>-- <br><div dir="ltr"><div><div>==</div><div>Our support, Your Success! \
Visit <a href="http://opensdi.geo-solutions.it" \
target="_blank">http://opensdi.geo-solutions.it</a> for more \
information.</div><div>==</div>
</div><div><br></div><div>Ing. Andrea Aime \
<br></div><div>@geowolf</div><div>Technical \
Lead</div><div><br></div><div>GeoSolutions S.A.S.</div><div>Via Poggio alle Viti \
1187</div><div>55054 Massarosa (LU)</div><div>Italy</div>
<div>phone: +39 0584 962313</div><div>fax: +39 0584 1660272</div><div>mob: +39 339 \
8844549</div><div><br></div><div><a href="http://www.geo-solutions.it" \
target="_blank">http://www.geo-solutions.it</a></div><div><a \
href="http://twitter.com/geosolutions_it" \
target="_blank">http://twitter.com/geosolutions_it</a></div>
<div><br></div><div>-------------------------------------------------------</div></div>
</div></div>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic