[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] request for review: JDK-8007386 On physical machine (video card is Intel Q45)th
From: Johnny Chen <jia-hong.chen () oracle ! com>
Date: 2013-09-30 23:05:20
Message-ID: D5DC9BE0-4C4D-42AD-A6A9-DE9B991FE804 () oracle ! com
[Download RAW message or body]
Hi,
Should:
if(major <= 3 && minor < 5)
be changed to:
if (major < 3 || (major == 3 && minor < 5))
Thanks,
Johnny Chen
On Sep 30, 2013, at 3:39 PM, Phil Race <philip.race@oracle.com> wrote:
> This looks good to me. I am running it through our build system just to be sure
> but I don't anticipate any problems.
>
> 2nd reviewer ?
>
> -phil.
>
> On 9/28/2013 3:26 PM, Clemens Eisserer wrote:
>> Hi Phil,
>>
>>> Shouldn't most of this be inside an "ifdef _linux_ ?
>>> Solaris & (currently) even MacOS will compile this code.
>> Thanks for the pointer, I completely forgot about OSX (solaris should
>> work as-is).
>> Please find an updated version at:
>> http://cr.openjdk.java.net/~ceisserer/8007386/webrev.02/
>>
>> - Clemens
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space; \
">Hi,<div><br></div><div>Should:</div><div><span style="color: blue; font-weight: \
bold; background-color: rgb(238, 238, 238); ">if(major <= 3 && minor < \
5)</span></div><div><div><br></div><div>be changed to:</div><div>if (major < 3 || \
(major == 3 && minor < 5))</div><div> <div style="color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; \
text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: \
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; "><br \
class="Apple-interchange-newline">Thanks,</div><div style="color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; \
text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: \
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; ">Johnny Chen</div>
</div>
<br><div><div>On Sep 30, 2013, at 3:39 PM, Phil Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite">This looks good to me. I am \
running it through our build system just to be sure<br>but I don't anticipate any \
problems.<br><br>2nd reviewer ?<br><br>-phil.<br><br>On 9/28/2013 3:26 PM, Clemens \
Eisserer wrote:<br><blockquote type="cite">Hi Phil,<br><br><blockquote \
type="cite">Shouldn't most of this be inside an "ifdef _linux_ ?<br>Solaris & \
(currently) even MacOS will compile this code.<br></blockquote>Thanks for the \
pointer, I completely forgot about OSX (solaris should<br>work as-is).<br>Please find \
an updated version at:<br><a \
href="http://cr.openjdk.java.net/~ceisserer/8007386/webrev.02/">http://cr.openjdk.java.net/~ceisserer/8007386/webrev.02/</a><br><br>- \
Clemens<br></blockquote><br></blockquote></div><br></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic