[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] Review request for http://cr.openjdk.java.net/~ceisserer/fix10/
From: Johnny Chen <jia-hong.chen () oracle ! com>
Date: 2013-09-26 22:59:43
Message-ID: 075E5D96-746A-455C-862A-840064E6D6A9 () oracle ! com
[Download RAW message or body]
Looks good!
Thanks,
Johnny Chen
On Sep 26, 2013, at 12:04 PM, Clemens Eisserer <linuxhippy@gmail.com> wrote:
> Hi Phil,
>
>> the webrev and test need a little clean-up : adding the @test and @bug tag +
>> GPL
>
> Please find a corrected version at
> http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/
> along with a (hopefully) jtreg conformant testcase at
> http://cr.openjdk.java.net/~ceisserer/8024895/EABlitTest.java
>
>> Other than that the fix is fine although without looking at bit more broadly
>> I'm unsure how this cache works in a MT scenario.
>
> It is guarded by the AWT-lock, but you're right - it is not benefitial
> (but doesn't hurt either) under some circumstances.
>
> Thanks, Clemens
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space; ">Looks good!<br><div> <div \
style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: \
normal; font-variant: normal; font-weight: normal; letter-spacing: normal; \
line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; \
text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; \
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><br \
class="Apple-interchange-newline">Thanks,</div><div style="color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; \
text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: \
normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; ">Johnny Chen</div>
</div>
<br><div><div>On Sep 26, 2013, at 12:04 PM, Clemens Eisserer <<a \
href="mailto:linuxhippy@gmail.com">linuxhippy@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite">Hi Phil,<br><br><blockquote \
type="cite">the webrev and test need a little clean-up : adding the @test and @bug \
tag +<br>GPL<br></blockquote><br>Please find a corrected version at<br><a \
href="http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/">http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/</a><br>along \
with a (hopefully) jtreg conformant testcase \
at<br>http://cr.openjdk.java.net/~ceisserer/8024895/EABlitTest.java<br><br><blockquote \
type="cite">Other than that the fix is fine although without looking at bit more \
broadly<br>I'm unsure how this cache works in a MT scenario.<br></blockquote><br>It \
is guarded by the AWT-lock, but you're right - it is not benefitial<br>(but doesn't \
hurt either) under some circumstances.<br><br>Thanks, \
Clemens<br></blockquote></div><br></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic