[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from 6u1
From:       anton nashatyrev <anton.nashatyrev () oracle ! com>
Date:       2013-09-12 16:42:36
Message-ID: 5231EEFC.8070400 () oracle ! com
[Download RAW message or body]

Hello,
     could you please review the following fix:

fix: http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00 
<http://cr.openjdk.java.net/%7Ealitvinov/8023990/webrev.00>
bug: https://bugs.openjdk.java.net/browse/JDK-8023990

      When the FcFontConfiguration was added for using fontconfig on a 
set of Linux platforms (as well as OpenSolaris) (the corresponding rfe 
is here <https://bugs.openjdk.java.net/browse/JDK-8023990>), the 
implementation of the method FcFontConfiguration.getFontDescriptors() 
returned just an empty array. This functionality is actually not used by 
anyone except of the PSPrinterJob which tries to find out whether the 
string could be represented using PS embedded font. If this procedure 
fails then the PSPrinterJob falls back to glyphs outline printing. As I 
understand this normally happened for strings containing non-ASCII 
characters. For ASCII strings PSPrinterJob usually selected the PS 
embedded font. With the addition of FcFontConfiguration even ASCII 
strings output starts to fall back to outlines.

     The fix is some basic implementation of the getFontDescriptors() 
functionality. The returned FontDecriptors don't contain missing glyph 
information. Though it might be queried from the fontconfig library 
(with some additional effort) this doesn't change the behavior of 
PSPrinterJob, since all the fonts has the ISO 10646 encoding (UTF-8), 
and the PSPrinterJob will still be falling back to outlines for any 
non-ASCII strings.

Thanks!
Anton.

[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hello, <br>
        could you please review the following fix:<br>
    <br>
    fix: <a
      href="http://cr.openjdk.java.net/%7Ealitvinov/8023990/webrev.00">http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00</a><br>
  bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8023990">https://bugs.openjdk.java.net/browse/JDK-8023990</a><br>
  <br>
         When the FcFontConfiguration was added for using fontconfig on
    a set of Linux platforms (as well as OpenSolaris) (the corresponding
    rfe is <a href="https://bugs.openjdk.java.net/browse/JDK-8023990">here</a>),
    the implementation of the method
    FcFontConfiguration.getFontDescriptors() returned just an empty
    array. This functionality is actually not used by anyone except of
    the PSPrinterJob which tries to find out whether the string could be
    represented using PS embedded font. If this procedure fails then the
    PSPrinterJob falls back to glyphs outline printing. As I understand
    this normally happened for strings containing non-ASCII characters.
    For ASCII strings PSPrinterJob usually selected the PS embedded
    font. With the addition of FcFontConfiguration even ASCII strings
    output starts to fall back to outlines.<br>
    <br>
        The fix is some basic implementation of the getFontDescriptors()
    functionality. The returned FontDecriptors don't contain missing
    glyph information. Though it might be queried from the fontconfig
    library (with some additional effort) this doesn't change the
    behavior of PSPrinterJob, since all the fonts has the ISO 10646
    encoding (UTF-8), and the PSPrinterJob will still be falling back to
    outlines for any non-ASCII strings.<br>
    <br>
    Thanks! <br>
    Anton. <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic