[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Please review patch for bug 7189452
From:       philip.race () oracle ! com (Phil Race)
Date:       2012-08-09 19:40:53
Message-ID: 50241245.5000508 () oracle ! com
[Download RAW message or body]

Looks ok to me.

-phil.

On 8/6/2012 12:20 PM, Clemens Eisserer wrote:
> Hi,
>
> During playing with bug 7082809 (which will require some more time to
> fix), I discovered another bug: 7189452
> When rendering text with an xrender-surface as source (texturepaint,
> gradientpaint), the pipeline doesn't adjust the offset of the
> source-surface relative to the glyph list.
> This leads to artifacts like in the attached image (left xrender,
> right reference).
>
> Please review my fix for this issue:
> http://cr.openjdk.java.net/~ceisserer/7189452/webrev.00/
>
> Is it ok to simly cast the glyphlist-offset to an integral type or
> should I better use rounding?
> A way to archive higher precision would be to adjust the
> transformation of the source-surface, however that would require quite
> a bit of extra code (as well as cycles).
>
>
> Thank you in advance, Clemens


[prev in list] [next in list] [prev in thread] [next in thread]