[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files
From:       magnus.ihse.bursie () oracle ! com (Magnus Ihse Bursie)
Date:       2012-05-22 8:06:41
Message-ID: 4FBB4911.3000103 () oracle ! com
[Download RAW message or body]

On 2012-05-22 03:48, Kelly O'Hair wrote:
> On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote:
> 
> > On 2012-05-02 00:19, Kelly Ohair wrote:
> > > Magnus,
> > > 
> > > Do you still need this integrated?
> > > I can integrate the exact same changset to awt, 2d,  and build forests if you \
> > > want.
> > Yes, I still like to have this integrated. (Sorry for the slow response, it's \
> > been a bit low on the priority list.) Otherwise we need to add a \
> > @GenerateNativeHeaders annotation to a class that only generates an empty header \
> > file, and that looks kind of silly. :-) 
> > /Magnus
> 
> Is this the patch I need to integrate?
> http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/

Yes.
> And who do I put down as the reviewers?

 From the mail replies:
Anthony Petrov <anthony.petrov at oracle.com>
Chris Hegarty <chris.hegarty at oracle.com>
Phil Race <philip.race at oracle.com>

/Magnus


[prev in list] [next in list] [prev in thread] [next in thread]