[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files
From:       chris.hegarty () oracle ! com (Chris Hegarty)
Date:       2012-04-30 10:16:48
Message-ID: 4F9E6690.4080601 () oracle ! com
[Download RAW message or body]

On 27/04/2012 21:37, Jim Graham wrote:
> Thanks, sorry, I missed the part where this was responding to a change
> that is already under way in the new build system...

Right, but it would be nice to trivially cleanup (remove these files) 
from FILES_export list in the old build system.

-Chris.

>
> ...jim
>
> On 4/26/12 12:35 AM, Magnus Ihse Bursie wrote:
>> On 2012-04-26 03:06, Jim Graham wrote:
>>> Can we remove these "empty JNI" classes from a list of "javah" classes
>>> somewhere so that we don't waste time generating the empty JNI headers?
>>
>> Good idea -- that's exactly what is being done in the new build system
>> (the build-infra project)! :-)
>>
>> We added a new option to javac, which generates JNI headers
>> automatically, if they are needed -- basically, if the class contains
>> native methods *). So header generation is made always when needed and
>> only when needed, quickly and as a part of normal compilation.
>>
>> Since these classes didn't have any native methods, the header files
>> were not generated, and the compile of the native code failed since the
>> #include pointed to non-exisiting files.
>>
>> *) Actually, sometimes classes with constants but without native methods
>> are needed. In this case, the new annotation @GenerateNativeHeader is
>> needed.
>>
>> /Magnus

[prev in list] [next in list] [prev in thread] [next in thread]