[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while n
From:       james.graham () oracle ! com (Jim Graham)
Date:       2011-04-27 23:22:23
Message-ID: 4DB8A52F.60105 () oracle ! com
[Download RAW message or body]

Hi Mario,

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6982632

Unfortunately these changes you made back in October to lazily install 
the loops and leave it null have broken an internal test case (see bugid 
6982632 above).  This test was in the closed repository of tests, but 
after looking at it I think it should be moved to the open set of tests 
as there is nothing proprietary about it.  I've attached the test case 
so you can take a look at it and see how you think we should fix this.

The test case is making sure that we don't crash if multiple threads 
modify the same Graphics2D object.  Note that we don't support the 
results of doing that, but we do have an implicit promise not to crash 
even if they abuse the object.

With your changes we don't crash, but the test can't be run because it 
generates a lot of NPE exceptions whenever a rendering operation happens 
to catch a window where the loops are null.

We can fix this either by:

- Modifying the test case so that it caches exceptions and ignores them 
and keeps plowing on abusing the graphics to make sure that we don't crash.

- Decide that perhaps exceptions are also behaviorally incompatible and 
find a way to modify your fix so that it never leaves the loops null and 
so we never get an NPE as a result.  This would likely involve creating 
a dummy set of NOP loops and installing them whenever we would have set 
them to null.

In either case we should push the test case into the Open sources at 
test/java/awt/Graphics2D/MTGraphicsAccessTest/[].java when the bug is 
resolved.  Note that it gets a lot more bureaucratic to push fixes after 
the end of this week so it would be nice to get this in quickly before 
the bar lowers...

			...jim

On 10/30/2009 11:24 AM, Mario Torre wrote:
> Il 30/10/2009 18:50, Jennifer Godinez ha scritto:
>> Hi Mario,
>>
>> Since you are pushing the fix yourself, you don't really need the
>> "Contributed-by". This is used for someone pushing it for you.
>>
>> Jennifer
>
> Hi Jennifer, Jim and all,
>
> Committed!
>
> Thanks for the help, I'll celebrate with some Port wine tonight :)
>
> Cheers!
> Mario
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MTGraphicsAccessTest.java
Type: java/*
Size: 11654 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20110427/e9205787/attachment.bin 

[prev in list] [next in list] [prev in thread] [next in thread]