[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Fixes for two bugs in stroker
From:       dlila () redhat ! com (Denis Lila)
Date:       2010-09-22 13:30:16
Message-ID: 1320037402.239141285162216722.JavaMail.root () zmail04 ! collab ! prod ! int ! phx2 ! redhat ! com
[Download RAW message or body]

Hello Omair.

I'm sorry it took me so long to get to this.
The first patch looks good.
The second one breaks miter joins for counter clockwise paths. For
example, if the path is p.moveTo(0, 0);p.lineTo(0, 100);p.lineTo(100,100);
p.lineTo(100,0);p.closePath(); the miter join on the close won't be
drawn properly and new artifacts will be introduced on round joins (bevel
joins will simply not be drawn).

PS. I don't think that this (bug 6850438) is a bug. The specification
is a bit loose on the behaviour of BasicStroke.createStrokedShape. As
long as the created shape is filled properly, the behaviour is correct.
It would probably be a good idea to reclassify this as a RFE.
Anyway, the last thing I've been working on fixes this:
http://icedtea.classpath.org/~dlila/webrevs/noflatten/webrev/

Regards,
Denis.

----- "Omair Majid" <omajid at redhat.com> wrote:

> Hi,
> 
> A while ago I filed
> http://bugs.openjdk.java.net/show_bug.cgi?id=100046
> and
> http://bugs.openjdk.java.net/show_bug.cgi?id=100047
> which contain fixes for two bugs in lines drawn by the Stroker. Will 
> someone be kind enough to review these patches? The bug reports
> contain 
> patches and images showing the differences in output.
> 
> Thanks,
> Omair

[prev in list] [next in list] [prev in thread] [next in thread]