[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Please review change in regression test sun/java2d/DirectX/OnScreenRenderingResizeT
From:       ptisnovs () redhat ! com (Pavel Tisnovsky)
Date:       2010-09-10 10:12:40
Message-ID: 4C8A0498.10706 () redhat ! com
[Download RAW message or body]

Hi,

can anybody please review the simple change in regression test
sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java?

Webrev containing this change is available here:
http://cr.openjdk.java.net/~ptisnovs/OnScreenRenderingResizeTest/

I replaced the call of a method Point.move() by Point.translate()
because this test did not work correctly in those cases when the top
(and probably left) screen area is occupied by a toolbar/panel (which is
the default settings for GNOME for example).

I've successfully tested this changed regression test on RHEL5 with
GNOME installed (with and without top panel).

Cheers
Pavel T.

PS: the name of the method Point.move() is a bit confusing for me as I
(and probably also author of the test) have thought it is similar to
Point.translate() ;-)

[prev in list] [next in list] [prev in thread] [next in thread]