[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] [PATCH] FontManager refactoring
From:       Phil.Race () Sun ! COM (Phil Race)
Date:       2009-02-10 4:10:09
Message-ID: 4990FE21.4030901 () sun ! com
[Download RAW message or body]

Roman Kennke wrote:
> annels on that file get
> closed before actually deleting the file. I don't know if it's
> considered a bug in File.deleteOnExit() if it fails when any channels
> are still open, I'd say yes, because cleaning up temporary files is what
> this API is made for. Should not be so difficult to implement. Just
> register all open channels w/ the file deletion hook, if there is one,
> and close them before deleting, just like we do in our hook.
>   

Well, there's a really, really old bug on this : 
http://bugs.sun.com/view_bug.do?bug_id=4171239
And whilst its number 15 on the bug parade, and the last update was a 
plan to fix it in 1.7
that was almost 3 years ago so I wouldn't count on it here.
> Anyway, here's the new webrev:
>
> http://kennke.org/~roman/fontmanager4/webrev/
>   

BTW did you see the code review server announcement. You could upload
the webrev there if you prefer, although zips we can archive are still 
desired.

More later ..

-phil.
> And the zipped version:
>
> http://kennke.org/~roman/fontmanager4.zip
>
> Have fun!
>
> /Roman
>
>   



[prev in list] [next in list] [prev in thread] [next in thread]