[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Still waiting for review
From:       Alexey.Ushakov () Sun ! COM (Alexey Ushakov)
Date:       2008-12-16 0:43:50
Message-ID: 4946F9C6.6060606 () sun ! com
[Download RAW message or body]

Hi Mark,

Here is an update on your fix concerning NPE in jfreechart&jxlayer applet.

After some debugging I've created following minimized test case 
reproducing the problem that you faced with. As you can see the problem 
was caused by empty clip set to the graphics. So, I'm going to extend 
your fix with some additional checks for empty clip at the higher level. 
Also, following test can be used as regression one for the fix we're 
working on. (It's actually common practice in jdk development to create 
regression tests for the fixes)

-------------------------------

public class Main extends JPanel {
    public static int WIDTH=200;
    public static int HEIGHT=200;
    public void paintComponent(Graphics g) {
        Graphics2D g2 = (Graphics2D)g;
        g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
                             RenderingHints.VALUE_ANTIALIAS_ON);
        g2.setRenderingHint(RenderingHints.KEY_STROKE_CONTROL, 
RenderingHints.VALUE_STROKE_PURE);

        g2.setClip(new Rectangle2D.Double(0, 0,0,0));
        g2.drawLine(0, 0, 100, 100);
    }

    public static void main(String[] args) {
        JFrame frame = new JFrame();
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.add(new Main());
        frame.setPreferredSize(new Dimension(WIDTH,HEIGHT));
        frame.pack();
        frame.setVisible(true);
    }

}

--------------
Best Regards,
Alexey

Alexey Ushakov wrote:
> Hi Mark,
>
> Please, read my comments about your patch.
>
> Sorry Martin, looks like this issue isn't yours.
>
> Best Regards,
> Alexey
>  
> Alexey Ushakov wrote:
>> Hi Martin,
>>
>> I'm currently looking into
>> http://www.jroller.com/dgilbert/entry/jfreechart_and_jxlayer
>>   
>> issue and your patch. Unfortunately we're all working in parallel on 
>> many different project, so I'm unable to dedicate all my time for 
>> this task.  Currently, I did verify that your fix does solve the 
>> problem but need more time to go through all the details of pisces AA 
>> engine to be sure that everything is OK. I'll let you know about any 
>> progress on this.
>>
>> Best Regards,
>> Alexey
>>
>> Martin von Gagern wrote:
>>> Hi Igor,
>>>
>>> thanks for your status update.
>>>
>>> Igor Nekrestyanov wrote:
>>>   
>>>> My understanding of current situation with Martin's fixes is the following:
>>>>  - for 2 of Martin's fixes internal formal review procedure is in progress
>>>>    (we do review all changes and save approved webrevs and this is
>>>>    another reason why we ask for webrevs for contributions)
>>>>    Unfortunately this procedure is not public and therefore it is hard
>>>>    to track it status. However, it should not take long.
>>>>     
>>>
>>> A short mail saying "Hi, I'm <youNameHere>, I'll now start to review
>>> this and get back to you when I have questions or reached a verdict"
>>> would be a first step towards tracking that state, until more elaborate
>>> tracking tools and mechanisms become available.
>>>
>>>   
>>>>  - one of the suggested fixes actually introduces incompatibility in the
>>>>    behavior
>>>>    and such change has to be reviewed by CCC committee (this is how we
>>>>    call it internally,
>>>>    not sure what will be public name when it become public process)
>>>>    [My understanding of incompatibility is: metadata written by "fixed"
>>>>    jdk will not be parsed normally by older jdk]
>>>>     
>>>
>>> Thanks, I'll look at this again, see if I have improvements or
>>> additional information to add regarding this. If so, I'll use the
>>> appropriate thread.
>>>
>>>   
>>>>   Andrew Brygin (who actually works on these 3 submissions) will provide
>>>> more accurate details about these 3 bugs later today.
>>>>     
>>>
>>> Great! Looking forward to that.
>>>
>>> Martin
>>>
>>>   
>>
>



[prev in list] [next in list] [prev in thread] [next in thread]