[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Bug fixes for	com.sun.imageio.plugins.png.PNGMetadata
From:       Igor.Nekrestyanov () Sun ! COM (Igor Nekrestyanov)
Date:       2008-11-10 22:58:07
Message-ID: 4918BC7F.5050702 () sun ! com
[Download RAW message or body]

Hi Martin,

yes, this is correct list for ImageIO fixes.

I am not ImageIO expert and someone who better understands this code 
will need to review this.
If changes are ok then we will integrate it acknowledging your contribution.

Usually it is more convenient to deal with independent issues 
separately. So, it was good idea to start several threads.

Patches are usually ok but it is actually much easier to review changes 
if you can generate webrev for suggested change, post it somethere
and send link to it. See 
http://blogs.sun.com/jcc/entry/webrev_for_openjdk_a_code

Also, i believe that 6541476 was recently fixed (change did not make 
into master workspace yet).
Please check latest 2d workspace and see if fix needs any further 
improvements.

-igor

Martin von Gagern wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi!
> 
> I've recently encountered a bunch of bugs in PNGMetadata:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5106550
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5082756
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6541476
> 
> For the first I have written a fix and posted it to jdk7-dev:
> http://mail.openjdk.java.net/pipermail/jdk7-dev/2008-October/000272.html
> After not getting a reply there, I asked in core-libs-dev, and was
> referred here.
> 
> I'm interested in contributing my fixes for these other issues as well.
> I might even look at some more IIO metadata bugs out there, see
> http://bugs.sun.com/bugdatabase/search.do?process=1&category=java&bugStatus=1%2C2%2C3%2C4%2C5%2C6%2C7%2C8%2C9&subcategory=imageio&type=bug&keyword=metadata
>  
> But before I start flooding this mailing list with them, I'd rather get
> some replies first.
> 
> 1. Is there someone going to sponsor this?
> 
> 2. Do you want them all in a single hg branch or rather multiple
> separate branches? I guess the issues would be independent enough to
> allow bultiple independent branches.
> 
> 3. How about mailing threads? One thread per bug report?
> 
> 4. I tend to have multiple commits per fix. Do you want a diff for each,
> or rather a single hg bundle containing them all, or both of this?
> 
> 5. Would you prefer a public hg branch somewhere to exchange the current
> state of affairs?
> 
> Greetings,
> Martin von Gagern
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.9 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iEYEARECAAYFAkkVp10ACgkQRhp6o4m9dFthsQCeIKpzPO/GM5ieuQfkHeW/PaHi
> wBMAnj7jwafJBnCf44our/dDu0sD0xwI
> =z2PP
> -----END PGP SIGNATURE-----
> 


[prev in list] [next in list] [prev in thread] [next in thread]