[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] <AWT Dev> [PATCH]	SwingUtilities2.isLocalDisplay()
From:       mario.torre () aicas ! com (Mario Torre)
Date:       2008-09-10 23:15:54
Message-ID: 1221088554.3336.17.camel () nirvana
[Download RAW message or body]

Il giorno mer, 10/09/2008 alle 15.45 -0700, Dmitri Trembovetski ha
scritto:

> --- a/src/solaris/native/sun/awt/fontpath.c	Thu Aug 07 09:42:31 2008 -0700
> +++ b/src/solaris/native/sun/awt/fontpath.c	Wed Sep 10 23:52:15 2008 +0200
> @@ -156,7 +156,7 @@
> 
>       isLocal = JNU_CallStaticMethodByName(env, NULL,
>                                            "sun/awt/X11GraphicsEnvironment",
> -                                         "isDisplayLocal",
> +                                         "_isDisplayLocal",
>                                            "()Z").z;

Hi Dmitri!

Calling "isDisplayLocal" fires up a infinite loop. Here we call
_isDisplayLocal, which is declared as:

private static boolean _isDisplayLocal

And we don't touch it in the patch.

We are not super happy with this, but I don't see much alternatives.
This code is X11 specific anyway.

All this Font code is really sensible to this kind of infinite loops...

Cheers,
Mario
-- 
?Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-53
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/



[prev in list] [next in list] [prev in thread] [next in thread]