[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] LCMS stale native method
From:       Phil.Race () Sun ! COM (Phil Race)
Date:       2008-05-28 20:02:22
Message-ID: 483DBA4E.9060409 () sun ! com
[Download RAW message or body]

Roman,

Sounds right. The native method declaration in LCMS.java appears to be
superseded by the non-JNI function which I see is used in LCMS.c

     Disposer_AddRecord(env, disposerRef, LCMS_freeTransform, sTrans.j);

I filed 6708093 :Redundant unused native method declaration in LCMS.java

-phil.


Roman Kennke wrote:
> I notice that there is a native method freeTransform() in LCMS.java, but
> LCMS.c doesn't have an implementation for that. There is only
> LCMS_freeTransform(), which of course isn't a JNI method. It could
> easily be implemented like this:
> 
> JNIEXPORT void JNICALL
> Java_sun_java2d_cmm_lcms_LCMS_freeTransform(JNIEnv* env, jclass cls,
> jlong id) {
>   LCMS_freeTransform(env, id);
> }
> 
> Wondering, why this never showed up anywhere, I digged a little deeper
> an looked around for possible callers of freeTransform(), but found
> none. Considering this, I think this must be a stale method maybe left
> from some earlier experiments and could be removed now. Is this correct?
> In this case, I would propose to remove the native method declaration.
> 
> Cheers, Roman
> 


[prev in list] [next in list] [prev in thread] [next in thread]