[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-devel
Subject:    Re: [oe] [meta-oe][PATCH] libosinfo: build vapi only if gobject-introspection is enabled
From:       "Martin Jansa" <Martin.Jansa () gmail ! com>
Date:       2023-08-30 17:31:36
Message-ID: CA+chaQeJ=PazOmdkHbwnCjE7ZmRMV=6FqpMFMSG+v-9DBfKZtQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

On Wed, Aug 30, 2023 at 6:23 PM Markus Volk <f_l_k@t-online.de> wrote:

> this fixes:
> meson.build:40:8: ERROR: Problem encountered: vala support was requested,
> but introspection support is mandatory.
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta-oe/recipes-support/libosinfo/libosinfo_1.10.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-support/libosinfo/libosinfo_1.10.bb
> b/meta-oe/recipes-support/libosinfo/libosinfo_1.10.bb
> index b02bc1281..d724c52ea 100644
> --- a/meta-oe/recipes-support/libosinfo/libosinfo_1.10.bb
> +++ b/meta-oe/recipes-support/libosinfo/libosinfo_1.10.bb
> @@ -23,10 +23,10 @@ GIR_MESON_ENABLE_FLAG = 'enabled'
>  GIR_MESON_DISABLE_FLAG = 'disabled'
>  GTKDOC_MESON_OPTION = "enable-gtk-doc"
>
> -EXTRA_OEMESON = " \
> +EXTRA_OEMESON += " \
>         -Dwith-pci-ids-path=${datadir}/pci.ids \
>         -Dwith-usb-ids-path=${datadir}/usb.ids \
> -       -Denable-vala=enabled \
> +       ${@bb.utils.contains('GI_DATA_ENABLED', 'True',
> '-Denable-vala=enabled', '-Denable-vala=disabled', d)} \
>  "
>
>  RDEPENDS:${PN} = "pciutils-ids usbids"
> --
> 2.41.0
>
>
> 
>
>

[Attachment #5 (text/html)]

<div dir="ltr">Acked-by: Martin Jansa &lt;<a \
href="mailto:Martin.Jansa@gmail.com">Martin.Jansa@gmail.com</a>&gt;<br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 30, 2023 at \
6:23 PM Markus Volk &lt;<a \
href="mailto:f_l_k@t-online.de">f_l_k@t-online.de</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">this fixes:<br> meson.build:40:8: ERROR: Problem \
encountered: vala support was requested, but introspection support is mandatory.<br> \
                <br>
Signed-off-by: Markus Volk &lt;<a href="mailto:f_l_k@t-online.de" \
                target="_blank">f_l_k@t-online.de</a>&gt;<br>
---<br>
  meta-oe/recipes-support/libosinfo/<a href="http://libosinfo_1.10.bb" \
rel="noreferrer" target="_blank">libosinfo_1.10.bb</a> | 4 ++--<br>  1 file changed, \
2 insertions(+), 2 deletions(-)<br> <br>
diff --git a/meta-oe/recipes-support/libosinfo/<a href="http://libosinfo_1.10.bb" \
rel="noreferrer" target="_blank">libosinfo_1.10.bb</a> \
b/meta-oe/recipes-support/libosinfo/<a href="http://libosinfo_1.10.bb" \
rel="noreferrer" target="_blank">libosinfo_1.10.bb</a><br> index b02bc1281..d724c52ea \
                100644<br>
--- a/meta-oe/recipes-support/libosinfo/<a href="http://libosinfo_1.10.bb" \
                rel="noreferrer" target="_blank">libosinfo_1.10.bb</a><br>
+++ b/meta-oe/recipes-support/libosinfo/<a href="http://libosinfo_1.10.bb" \
rel="noreferrer" target="_blank">libosinfo_1.10.bb</a><br> @@ -23,10 +23,10 @@ \
GIR_MESON_ENABLE_FLAG = &#39;enabled&#39;<br>  GIR_MESON_DISABLE_FLAG = \
&#39;disabled&#39;<br>  GTKDOC_MESON_OPTION = &quot;enable-gtk-doc&quot;<br>
<br>
-EXTRA_OEMESON = &quot; \<br>
+EXTRA_OEMESON += &quot; \<br>
            -Dwith-pci-ids-path=${datadir}/pci.ids \<br>
            -Dwith-usb-ids-path=${datadir}/usb.ids \<br>
-           -Denable-vala=enabled \<br>
+           ${@bb.utils.contains(&#39;GI_DATA_ENABLED&#39;, &#39;True&#39;, \
&#39;-Denable-vala=enabled&#39;, &#39;-Denable-vala=disabled&#39;, d)} \<br>  \
&quot;<br> <br>
  RDEPENDS:${PN} = &quot;pciutils-ids usbids&quot;<br>
-- <br>
2.41.0<br>
<br>
<br>
<br>
<br>
</blockquote></div>



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#104676): https://lists.openembedded.org/g/openembedded-devel/message/104676
Mute This Topic: https://lists.openembedded.org/mt/101056232/4455120
Group Owner: openembedded-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [openembedded-devel@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]