[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-devel
Subject:    Re: [oe] [meta-oe][PATCH] thrift: Remove buildpaths
From:       "Yu, Mingli" <mingli.yu () eng ! windriver ! com>
Date:       2023-08-30 8:39:04
Message-ID: 254cf86d-6836-4d69-55f9-517b0b9fafa0 () windriver ! com
[Download RAW message or body]

Hi Khem,

On 8/30/23 00:14, Khem Raj wrote:
> **
> *CAUTION: This email comes from a non Wind River email account!*
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
> 
> 
> On Tue, Aug 29, 2023 at 2:54 AM Yu, Mingli <mingli.yu@eng.windriver.com 
> <mailto:mingli.yu@eng.windriver.com>> wrote:
> 
> From: Mingli Yu <mingli.yu@windriver.com
> <mailto:mingli.yu@windriver.com>>
> 
> Fixes:
> WARNING: thrift-0.18.1-r0 do_package_qa: QA Issue: File
> /usr/lib64/cmake/thrift/thriftnbTargets.cmake in package thrift-dev
> contains reference to TMPDIR
> File /usr/lib64/cmake/thrift/thrift_c_glibTargets.cmake in
> package thrift-dev contains reference to TMPDIR
> File /usr/lib64/cmake/thrift/thrift_c_glib_zlibTargets.cmake in
> package thrift-dev contains reference to TMPDIR [buildpaths]
> WARNING: thrift-0.18.1-r0 do_package_qa: QA Issue: File
> /usr/src/debug/thrift/0.18.1-r0/compiler/cpp/thrift/thrifty.hh in
> package thrift-src contains reference to TMPDIR
> File
> /usr/src/debug/thrift/0.18.1-r0/compiler/cpp/thrift/thrifty.cc
> <https://urldefense.com/v3/__http://thrifty.cc__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGUpfdhVA$>
>  in package thrift-src contains reference to TMPDIR
> File
> /usr/src/debug/thrift/0.18.1-r0/compiler/cpp/thrift/thriftl.cc
> <https://urldefense.com/v3/__http://thriftl.cc__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGLv1WKXA$>
>  in package thrift-src contains reference to TMPDIR [buildpaths]
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com
> <mailto:mingli.yu@windriver.com>>
> ---
> meta-oe/recipes-connectivity/thrift/thrift_0.18.1.bb
> <https://urldefense.com/v3/__http://thrift_0.18.1.bb__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGr8mRPcY$>
>  | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/meta-oe/recipes-connectivity/thrift/thrift_0.18.1.bb
> <https://urldefense.com/v3/__http://thrift_0.18.1.bb__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGr8mRPcY$>
>  b/meta-oe/recipes-connectivity/thrift/thrift_0.18.1.bb
> <https://urldefense.com/v3/__http://thrift_0.18.1.bb__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGr8mRPcY$>
>  index ea5a3972d..2809e24ad 100644
> --- a/meta-oe/recipes-connectivity/thrift/thrift_0.18.1.bb
> <https://urldefense.com/v3/__http://thrift_0.18.1.bb__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGr8mRPcY$>
>                 
> +++ b/meta-oe/recipes-connectivity/thrift/thrift_0.18.1.bb
> <https://urldefense.com/v3/__http://thrift_0.18.1.bb__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTGr8mRPcY$>
>  @@ -35,6 +35,8 @@ EXTRA_OECMAKE = " \
> -DWITH_OPENSSL=ON \
> -DWITH_QT5=OFF \
> -DWITH_ZLIB=ON \
> +      -DFLEX_TARGET_ARG_COMPILE_FLAGS='--noline' \
> +      -DBISON_TARGET_ARG_COMPILE_FLAGS='--no-lines' \
> "
> 
> PACKAGECONFIG ??= "glib libevent"
> @@ -46,6 +48,10 @@ PACKAGECONFIG[python] =
> "-DWITH_PYTHON=ON,-DWITH_PYTHON=OFF,python"
> 
> do_install:append () {
> ln -sf thrift ${D}/${bindir}/thrift-compiler
> +      # remove absolute paths
> +      sed -i -e 's|${RECIPE_SYSROOT}||g'
> ${D}${libdir}/cmake/thrift/thriftnbTargets.cmake
> +      sed -i -e 's|${RECIPE_SYSROOT}||g'
> ${D}${libdir}/cmake/thrift/thrift_c_glibTargets.cmake
> +      sed -i -e 's|${RECIPE_SYSROOT}||g'
> ${D}${libdir}/cmake/thrift/thrift_c_glib_zlibTargets.cmake
> 
> 
> Are these still working ok on target it would be good to check that 
> while you are here. I know they don't work before this patch perhaps
> 

Yes, the previous path which includes buildpath doesn't work on target.

And I don't verify if if works after the buildpath removed and will 
provide the update if I have then.

Thanks,

> 
> }
> 
> LEAD_SONAME = "libthrift.so
> <https://urldefense.com/v3/__http://libthrift.so__;!!AjveYdw8EvQ!aQBYHC3Pp7A3cjHlbgj3EQEtTprk19AI3swVtDGwMH3pVrcOrMyylWFw84z8G08tvZGSQ0q5xzlUFlTG-uCL9Fk$>.${PV}"
>                 
> -- 
> 2.25.1
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#104664): https://lists.openembedded.org/g/openembedded-devel/message/104664
Mute This Topic: https://lists.openembedded.org/mt/101028035/4455120
Group Owner: openembedded-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [openembedded-devel@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]