[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-devel
Subject:    [oe] [meta-java][PATCH 3/3] jamvm/java: allow spaces in arguments
From:       eric () eukrea ! com (Eric =?ISO-8859-1?B?QuluYXJk?=)
Date:       2013-09-30 19:44:16
Message-ID: 20130930214416.4922028a () e6520eb
[Download RAW message or body]

Le Mon, 30 Sep 2013 22:22:32 +0300,
Riku Voipio <riku.voipio at linaro.org> a ?crit :

> On 30 September 2013 16:58, Eric B?nard <eric at eukrea.com> wrote:
> > Hi Riku,
> > 
> > Le Mon, 30 Sep 2013 16:46:11 +0300,
> > Riku Voipio <riku.voipio at linaro.org> a ?crit :
> > 
> > > Current IFS mangling blows up on the face:
> > > 
> > > > configure:2341: javac  -classpath .: Test.java
> > > > Invalid maximum heap size: -Xmx1024m-cp/srv/oe/b
> > > 
> > > Simpler command line expansion works just as easy.
> > > ---
> > > recipes-core/jamvm/files/java | 7 +++----
> > > 1 file changed, 3 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/recipes-core/jamvm/files/java b/recipes-core/jamvm/files/java
> > > index 27cf094..9a396a7 100755
> > > --- a/recipes-core/jamvm/files/java
> > > +++ b/recipes-core/jamvm/files/java
> > > @@ -1,6 +1,5 @@
> > > #!/bin/sh
> > > 
> > > -IFS=""
> > > -export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:STAGING_LIBDIR_NATIVE/classpath:STAGING_LIBDIR_NATIVE/jamvm"
> > >                 
> > > -export BOOTCLASSPATH="STAGING_DATADIR_NATIVE/jamvm/classes.zip:STAGING_DATADIR_NATIVE/classpath/glibj.zip"
> > >                 
> > > -exec jamvm ${1+"$@"}
> > > +export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/srv/oe/build/tmp-eglibc/sysroots/x86_ \
> > > 64-linux/usr/lib/classpath:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/lib/jamvm"
> > >  +export BOOTCLASSPATH="/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share \
> > > /jamvm/classes.zip:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share/classpath/glibj.zip"
> > >  +exec jamvm "$@"
> 
> > so now we have your path "/srv/oe/build/tmp-eglibc/" hardcoded in the
> > recipe ;-)
> 
> That is indeed not intended.. I was a bit uncertain with this patch,
> as it was not clear to me why the IFS setting was needed.
> 
sorry can't help you on this point but I've added in copy Henning which
is the original author of this file and the maintainer of meta-java so
he must be the best placed to answer your question.

Eric



Eric


[prev in list] [next in list] [prev in thread] [next in thread]