[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-devel
Subject:    [oe] [oe-core] qemuarma9: Update qemuarma9-standard.scc definition.
From:       elvis.dowson () gmail ! com (Elvis Dowson)
Date:       2013-08-29 18:55:12
Message-ID: CFB8B97E-3126-42E1-8A32-CB02BFC4DE39 () gmail ! com
[Download RAW message or body]


On Aug 29, 2013, at 10:45 PM, Bruce Ashfield <bruce.ashfield at windriver.com> wrote:

> On 13-08-29 02:41 PM, Elvis Dowson wrote:
> > This commit
> > - updates the KMACHINE definition to vexpress.
> > - updates the branch to qemuarma9.
> > 
> > Signed-off-by: Elvis Dowson <elvis.dowson at gmail.com>
> > ---
> > meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc |    4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc \
> > b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc index \
> >                 c71fe1c..83911ff 100644
> > --- a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
> > +++ b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
> > @@ -1,9 +1,9 @@
> > -define KMACHINE qemuarma9
> > +define KMACHINE vexpress
> 
> There's no reason to delete the old machine, they are all valid
> and additive. Think of them as aliases. You can have as many
> as you want :)

In the kernel, there is no qemuarma9 machine. The corresponding
kernel machine is vexpress .. I checked the kernel sources, .. 
correct me if I'm wrong, but I thought the intent of the KMACHINE
variable was to map to the correct machine defined in the kernel.

> 
> > define KTYPE standard
> > define KARCH arm
> > 
> > include ktypes/standard/standard.scc
> > -branch arm-versatile-926ejs
> > +branch qemuarma9
> 
> There's no reason for a custom branch as well. Unless patches are
> being maintained that break compatibility with other boards.
> 


If we plan on having multiple arm architecture support (A8, A8, A15) to
QEMU, perhaps its better to rename this branch to qemuarm.

Best regards,

Elvis Dowson


[prev in list] [next in list] [prev in thread] [next in thread]