[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 0/3] Use frozen flag for cargo build
From:       "Alexander Kanavin" <alex.kanavin () gmail ! com>
Date:       2023-07-31 17:48:21
Message-ID: CANNYZj9-PaCUOp1jcuzzpNsU6Pde+LTGBSUHZGphNZPaLYPbFA () mail ! gmail ! com
[Download RAW message or body]

I think you need to better describe the benefits. What are the
improvements? Can we just stay with --offline?

There's lots of intricate code added around cargo.lock handling, with
special casing to revert to previous behavior via new variable, but
I'm struggling to understand: to what end?

Alex





On Mon, 31 Jul 2023 at 11:44, Frederic Martinsons
<frederic.martinsons@gmail.com> wrote:
>
> From: Frederic Martinsons <frederic.martinsons@gmail.com>
>
> This patch series force the usage of --frozen instead of --offline during cargo build.
> This has the advantage to be sure that Cargo.lock file will not be modified.
> Moreover, raise a clear error when Cargo.lock is not present.
> For this to work, we must modify ourself the Cargo.lock before building
> in case there are git repo that have been patched.
>
> The last commit is to handle the specific case of rust-hello-world recipe.
> If this recipe is no more necessary, we can drop this last patch.
>
> The following changes since commit 9b5b850d6a6982bb8ff14dcfbb6769b293638293:
>
>   libarchive: ignore CVE-2023-30571 (2023-07-30 12:00:13 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/fmartinsons/openembedded-core 15104-check-cargo-lock
>
> Frederic Martinsons (3):
>   cargo.bbclass: Use --frozen flag for cargo operations
>   cargo_common.bbclass: Handle Cargo.lock modifications for git
>     dependencies
>   cargo.bbclass: Offer a way to use --offline instead of --frozen
>
>  meta/classes-recipe/cargo.bbclass             |  9 +++-
>  meta/classes-recipe/cargo_common.bbclass      | 43 +++++++++++++++++++
>  .../rust-example/rust-hello-world_git.bb      |  2 +
>  3 files changed, 53 insertions(+), 1 deletion(-)
>
> --
> 2.34.1
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185156): https://lists.openembedded.org/g/openembedded-core/message/185156
Mute This Topic: https://lists.openembedded.org/mt/100458213/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]