[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] kernel-module-split add systemd modulesloaddir and modprobedir config
From:       "Jose Quaresma" <quaresma.jose () gmail ! com>
Date:       2023-06-30 15:54:57
Message-ID: CANPvuRmiGE58VewdOCuR+xbqVNBd1Lmoccy-0n-AcVrabGmFPg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

Forgot the colon in "kernel-module-split:"
is it necessary to send a v2 for this?

Jose

Jose Quaresma <quaresma.jose@gmail.com> escreveu no dia sexta, 30/06/2023
à (s) 16:49:

> Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> ---
>  meta/classes-recipe/kernel-module-split.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/kernel-module-split.bbclass
> b/meta/classes-recipe/kernel-module-split.bbclass
> index 0e4f9a6ec3..c1208d55e0 100644
> --- a/meta/classes-recipe/kernel-module-split.bbclass
> +++ b/meta/classes-recipe/kernel-module-split.bbclass
> @@ -30,8 +30,8 @@ fi
>
>  PACKAGE_WRITE_DEPS += "kmod-native depmodwrapper-cross"
>
> -modulesloaddir ??= "${sysconfdir}/modules-load.d"
> -modprobedir ??= "${sysconfdir}/modprobe.d"
> +modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> '${nonarch_libdir}', '${sysconfdir}', d)}/modules-load.d"
> +modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> '${nonarch_base_libdir}', '${sysconfdir}', d)}/modprobe.d"
>
>  KERNEL_SPLIT_MODULES ?= "1"
>  PACKAGESPLITFUNCS =+ "split_kernel_module_packages"
> --
> 2.34.1
>
>

-- 
Best regards,

José Quaresma

[Attachment #5 (text/html)]

<div dir="ltr">Hi,<br><br>Forgot the colon in &quot;kernel-module-split:&quot;  \
<div>is it necessary to send a v2 for this?<br><br>Jose</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Jose Quaresma &lt;<a \
href="mailto:quaresma.jose@gmail.com">quaresma.jose@gmail.com</a>&gt; escreveu no dia \
sexta, 30/06/2023 Ã (s) 16:49:<br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Signed-off-by: Jose Quaresma &lt;<a \
href="mailto:jose.quaresma@foundries.io" \
                target="_blank">jose.quaresma@foundries.io</a>&gt;<br>
---<br>
  meta/classes-recipe/kernel-module-split.bbclass | 4 ++--<br>
  1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/meta/classes-recipe/kernel-module-split.bbclass \
b/meta/classes-recipe/kernel-module-split.bbclass<br> index 0e4f9a6ec3..c1208d55e0 \
                100644<br>
--- a/meta/classes-recipe/kernel-module-split.bbclass<br>
+++ b/meta/classes-recipe/kernel-module-split.bbclass<br>
@@ -30,8 +30,8 @@ fi<br>
<br>
  PACKAGE_WRITE_DEPS += &quot;kmod-native depmodwrapper-cross&quot;<br>
<br>
-modulesloaddir ??= &quot;${sysconfdir}/modules-load.d&quot;<br>
-modprobedir ??= &quot;${sysconfdir}/modprobe.d&quot;<br>
+modulesloaddir ??= &quot;${@bb.utils.contains(&#39;DISTRO_FEATURES&#39;, \
&#39;systemd&#39;, &#39;${nonarch_libdir}&#39;, &#39;${sysconfdir}&#39;, \
d)}/modules-load.d&quot;<br> +modprobedir ??= \
&quot;${@bb.utils.contains(&#39;DISTRO_FEATURES&#39;, &#39;systemd&#39;, \
&#39;${nonarch_base_libdir}&#39;, &#39;${sysconfdir}&#39;, d)}/modprobe.d&quot;<br> \
<br>  KERNEL_SPLIT_MODULES ?= &quot;1&quot;<br>
  PACKAGESPLITFUNCS =+ &quot;split_kernel_module_packages&quot;<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div><br clear="all"><div><br></div><span \
class="gmail_signature_prefix">-- </span><br><div dir="ltr" \
class="gmail_signature"><div dir="ltr">Best regards,<div><br>José \
Quaresma</div></div></div>



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#183705): https://lists.openembedded.org/g/openembedded-core/message/183705
Mute This Topic: https://lists.openembedded.org/mt/99875687/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]