[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] bitbake.conf: Inject a dash into PN for BB_HASH_CODEPARSER_VALS
From:       "Martin Jansa" <Martin.Jansa () gmail ! com>
Date:       2023-01-30 12:47:15
Message-ID: CA+chaQe-CteA-B2tSz1nxQwCemoGVRZZBxYTNF7uZdEghgXFQA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


FWIW: this change doesn't help in the case I've reported earlier, because
the bbclass which was doing the split('-') was also checking that the
suffix was one of the supported values.

So I'll continue to use:
BB_HASH_CODEPARSER_VALS:remove = "PN=no-pn"
in that .bbclass.


On Fri, Jan 27, 2023 at 5:33 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> We've had a couple of reports of recipes expecting to be able to call
> split("-") on PN. There isn't any real harm in adding a dash to the dummy
> PN value to avoid these errors.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 5aadf6e7078..530b068757b 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -959,7 +959,7 @@ BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc deps depends \
>      sstate-lockfile-shared prefuncs postfuncs export_func deptask
> rdeptask \
>      recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename
> lineno \
>      progress mcdepends number_threads"
> -BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234
> PV=0.0-1 PN=nopn METADATA_REVISION=1234"
> +BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234
> PV=0.0-1 PN=no-pn METADATA_REVISION=1234"
>
>  MLPREFIX ??= ""
>  MULTILIB_VARIANTS ??= ""
> --
> 2.37.2
>
>
> 
>
>

[Attachment #5 (text/html)]

<div dir="ltr">FWIW: this change doesn&#39;t help in the case I&#39;ve reported \
earlier, because the bbclass which was doing the split(&#39;-&#39;) was also checking \
that the suffix was one of the supported values.<div><br></div><div>So I&#39;ll \
continue to use:</div><div>BB_HASH_CODEPARSER_VALS:remove = \
&quot;PN=no-pn&quot;<br></div><div>in that \
.bbclass.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, Jan 27, 2023 at 5:33 PM Richard Purdie &lt;<a \
href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We&#39;ve had a couple \
of reports of recipes expecting to be able to call<br> split(&quot;-&quot;) on PN. \
There isn&#39;t any real harm in adding a dash to the dummy<br> PN value to avoid \
these errors.<br> <br>
Signed-off-by: Richard Purdie &lt;<a href="mailto:richard.purdie@linuxfoundation.org" \
                target="_blank">richard.purdie@linuxfoundation.org</a>&gt;<br>
---<br>
  meta/conf/bitbake.conf | 2 +-<br>
  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf<br>
index 5aadf6e7078..530b068757b 100644<br>
--- a/meta/conf/bitbake.conf<br>
+++ b/meta/conf/bitbake.conf<br>
@@ -959,7 +959,7 @@ BB_SIGNATURE_EXCLUDE_FLAGS ?= &quot;doc deps depends \<br>
        sstate-lockfile-shared prefuncs postfuncs export_func deptask rdeptask \<br>
        recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename lineno \
\<br>  progress mcdepends number_threads&quot;<br>
-BB_HASH_CODEPARSER_VALS = &quot;LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 \
PN=nopn METADATA_REVISION=1234&quot;<br> +BB_HASH_CODEPARSER_VALS = &quot;LOGFIFO=/ \
T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 PN=no-pn METADATA_REVISION=1234&quot;<br> \
<br>  MLPREFIX ??= &quot;&quot;<br>
  MULTILIB_VARIANTS ??= &quot;&quot;<br>
-- <br>
2.37.2<br>
<br>
<br>
<br>
<br>
</blockquote></div>



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176489): https://lists.openembedded.org/g/openembedded-core/message/176489
Mute This Topic: https://lists.openembedded.org/mt/96569450/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]