[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH v2][master] go: Update reproducibility patch to fix panic errors
From:       "Richard Purdie" <richard.purdie () linuxfoundation ! org>
Date:       2022-11-29 15:16:27
Message-ID: 85366683dfe3845128d1396287cc2288e9c18663.camel () linuxfoundation ! org
[Download RAW message or body]

On Tue, 2022-11-29 at 08:42 -0600, Ryan Eatmon wrote:
> 
> On 11/29/2022 8:15, Richard Purdie wrote:
> > On Tue, 2022-11-29 at 06:23 -0600, Ryan Eatmon via
> > lists.openembedded.org wrote:
> > > Based on a discussion on the mailing list [1], there are panic
> > > errors that occur on a few platforms caused by the patch.  We
> > > cannot simply remove the original patch due to the
> > > reproducibility issues that it addresses, so this patch on the
> > > original patch fixes the cause of the panic errors.
> > > 
> > > The previous version of this patch was a little too aggressive
> > > in cleaning up the environment.  Some of the variables impacted
> > > by the filerCompilerFlags() function require at least one value
> > > to remain in the array.  In this case, the values for ccExe,
> > > cxxExe, and fcExe require a value or later code that access
> > > them result in a panic related to accessing a value out of range.
> > > 
> > > This updated patch adds a flag that requires keeping the first
> > > value so that at least one thing remains and the assignments
> > > for the Exes set that flag to true.  The first item in the
> > > array should be the executable name, so leaving it should be
> > > safe.
> > > 
> > > I have run the oe-selftest and everything passed in my setup.
> > > 
> > > There is a bug report [2] filed for the issue that this patch
> > > addresses.
> > > 
> > > [1] https://lists.openembedded.org/g/openembedded-core/topic/94022663
> > > [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14976
> > > 
> > > Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> > > ---
> > >   ...ent-based-hash-generation-less-pedan.patch | 30 ++++++++++---------
> > >   1 file changed, 16 insertions(+), 14 deletions(-)
> > 
> > If I remember rightly, the filter function removes anything starting
> > with -m. Are you saying you found a case where the executable itself
> > was called -m<something?
> > 
> > I'd like to understand what this was stripping out which was valid?
> 
> The function in the patch actually did the opposite.  It only keeps 
> values that start with -m.  I think what it was trying to strip out was 
> anything with a path.
> 
> Personally I think the way the original patch was implemented is like a 
> sledge hammer.  Which may be ok with how go integrates into OE, but 
> feels like overkill to me.

Ah, right. I suspect the issue is you can have --sysroot <X> or --
sysroot= which means removing one or two flags depending on the
context. I'd be happy to see the patch made to handle flags more
specifically though.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#173977): https://lists.openembedded.org/g/openembedded-core/message/173977
Mute This Topic: https://lists.openembedded.org/mt/95332822/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]