[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [kirkstone][PATCH] overlayfs: Allow not used mount points
From:       "Vyacheslav Yurkov" <uvv.mail () gmail ! com>
Date:       2022-10-31 15:46:46
Message-ID: dcc3de29-6fbb-0e3e-1cb6-71855b579966 () gmail ! com
[Download RAW message or body]

The patch is now in master. Just a reminder to queue it to kirkstone as 
well.

Thanks,
Vyacheslav

On 12.10.2022 18:40, Steve Sakoman wrote:
> On Tue, Oct 11, 2022 at 7:23 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote:
> > Just checking if something is missing to include this fix to kirkstone.
> Yes, it needs to make it into the master branch first :-) I will then
> cherry-pick for langdale and kirstone.
> 
> Richard is on holiday until 24 Oct, so it will occur shortly
> thereafter.  It is already queued for the master branch, so there is
> nothing else you need to do!
> 
> Steve
> 
> > On 05.10.2022 13:17, Vyacheslav Yurkov via lists.openembedded.org wrote:
> > > From: Vyacheslav Yurkov <Vyacheslav.Yurkov@bruker.com>
> > > 
> > > When machine configuration defines a mount point, which is not used in
> > > any recipe, allow to fall through and only report a note in the logs.
> > > This can be expected behavior, when a mount point is defined for several
> > > machines, but not used in all of them
> > > 
> > > Signed-off-by: Vyacheslav Yurkov <Vyacheslav.Yurkov@bruker.com>
> > > ---
> > > meta/classes/overlayfs.bbclass | 6 +++++-
> > > meta/lib/oe/overlayfs.py       | 6 +++++-
> > > 2 files changed, 10 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/meta/classes/overlayfs.bbclass b/meta/classes/overlayfs.bbclass
> > > index f7069edd41..c3564b6ec1 100644
> > > --- a/meta/classes/overlayfs.bbclass
> > > +++ b/meta/classes/overlayfs.bbclass
> > > @@ -96,7 +96,11 @@ python do_create_overlayfs_units() {
> > > overlayMountPoints = d.getVarFlags("OVERLAYFS_MOUNT_POINT")
> > > for mountPoint in overlayMountPoints:
> > > bb.debug(1, "Process variable flag %s" % mountPoint)
> > > -        for lower in d.getVarFlag('OVERLAYFS_WRITABLE_PATHS', \
> > > mountPoint).split(): +        lowerList = \
> > > d.getVarFlag('OVERLAYFS_WRITABLE_PATHS', mountPoint) +        if not lowerList:
> > > +            bb.note("No mount points defined for %s flag, skipping" % \
> > > (mountPoint)) +            continue
> > > +        for lower in lowerList.split():
> > > bb.debug(1, "Prepare mount unit for %s with data mount point %s" %
> > > (lower, d.getVarFlag('OVERLAYFS_MOUNT_POINT', mountPoint)))
> > > prepareUnits(d.getVarFlag('OVERLAYFS_MOUNT_POINT', mountPoint), lower)
> > > diff --git a/meta/lib/oe/overlayfs.py b/meta/lib/oe/overlayfs.py
> > > index b5d5e88e80..590c0de58a 100644
> > > --- a/meta/lib/oe/overlayfs.py
> > > +++ b/meta/lib/oe/overlayfs.py
> > > @@ -38,7 +38,11 @@ def unitFileList(d):
> > > bb.fatal("Missing required mount point for OVERLAYFS_MOUNT_POINT[%s] in your \
> > > MACHINE configuration" % mountPoint) 
> > > for mountPoint in overlayMountPoints:
> > > -        for path in d.getVarFlag('OVERLAYFS_WRITABLE_PATHS', \
> > > mountPoint).split(): +        mountPointList = \
> > > d.getVarFlag('OVERLAYFS_WRITABLE_PATHS', mountPoint) +        if not \
> > > mountPointList: +            bb.debug(1, "No mount points defined for %s flag, \
> > > don't add to file list", mountPoint) +            continue
> > > +        for path in mountPointList.split():
> > > fileList.append(mountUnitName(path))
> > > fileList.append(helperUnitName(path))
> > > 
> > > 
> > > 
> > > 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172326): https://lists.openembedded.org/g/openembedded-core/message/172326
Mute This Topic: https://lists.openembedded.org/mt/94132926/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]