[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [OE-core] Regression about go 1.18 + OE specific local patch
From: "Jose Quaresma" <quaresma.jose () gmail ! com>
Date: 2022-09-30 17:57:55
Message-ID: CANPvuR=W68vwb+r6yAZKmbf5Y08rVRjE6F7ON_ttfsc-Bk41VA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Qi,
With patch in place I have seen some build issues mainly in
meta-virtualization
with ti am62xx-evm, am64xx-evm and riscv64 machines.
Propose to remove the patch as it seams to fix the issue and I don't see
any side effect after
testing it in some weeks.
https://lists.openembedded.org/g/openembedded-core/message/171233
Chen Qi <Qi.Chen@windriver.com> escreveu no dia terça, 10/05/2022 à (s)
10:09:
> Hi All,
>
>
>
> I met a regression after go was upgraded to 1.18+.
>
> The problem can be reproduced by running `bitbake nativesdk-skopeo', with
> meta-virtualization added in bblayers.conf.
>
> The error message is as below.
>
>
>
> """
>
> <snip>
>
> > HASH[build golang.org/x/text/unicode/norm]: "import \"
> golang.org/x/text/unicode/norm\ <http://golang.org/x/text/unicode/norm%5C>
> "\n"
>
> > HASH
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-skopeo/v
>
> 1.6.1+gitAUTOINC+3e2defd6d3-r0/git/src/import/vendor/
> github.com/pkg/errors/errors.go: 1b60ba5bcb417f0060d1c1fbc
>
> edaa1a702020499094ce8134f8b45a58c0ebbff
>
> > panic: runtime error: index out of range [0] with length 0
>
> >
>
> > goroutine 5129 [running]:
>
> > cmd/go/internal/work.(*Builder).buildActionID(0xc0002490e0, 0xc000370b40)
>
> >
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:281
> +0x23cf
>
> > cmd/go/internal/work.(*Builder).build(0xc0002490e0, {0xc000220000?,
> 0x0?}, 0xc000370b40)
>
> >
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:476
> +0x199
>
> > cmd/go/internal/work.(*Builder).Do.func2({0xadd9f8, 0xc000220000},
> 0xc000370b40)
>
> >
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_ \
> 64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:139
> +0x5ec
>
> > cmd/go/internal/work.(*Builder).Do.func3()
>
> >
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_ \
> 64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:201
> +0xb9
>
> > created by cmd/go/internal/work.(*Builder).Do
>
> >
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_ \
> 64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:187
> +0x3da
>
> > Makefile:140: recipe for target 'bin/skopeo' failed
>
> <snip>
>
> """
>
>
>
> I did some investigation and found it was related to a local patch,
> 0001-cmd-go-make-content-based-hash-generation-less-pedan.patch.
>
> The build succeeded after I dropped this patch.
>
>
>
> I'm sending out this email to seek for some help, as I don't fully
> understand what this patch does.
>
>
>
> e.g.
>
> """
>
> + if strings.HasPrefix(flag, "-m") {
>
> + newflags = append(newflags, flag)
>
> + }
>
> """
>
> This flag filtering is not explained in the commit message.
>
>
>
> One more question: this patch applies to all go recipes, including go
> cross compilers and target go. But from its commit message, target go does
> not seem to need it.
>
>
>
> Any suggestion?
>
>
>
> Regards,
>
> Qi
>
>
>
>
>
>
>
>
--
Best regards,
José Quaresma
[Attachment #5 (text/html)]
<div dir="ltr"><div>Hi Qi,</div><div><br></div><div>W<span \
style="color:rgb(51,51,51);font-family:"Helvetica \
Neue",Helvetica,Arial,sans-serif;font-size:14px;white-space:pre-wrap">ith patch \
in place I have seen some build issues mainly in \
meta-virtualization</span></div><span \
style="color:rgb(51,51,51);font-family:"Helvetica \
Neue",Helvetica,Arial,sans-serif;font-size:14px;white-space:pre-wrap">with ti \
am62xx-evm, am64xx-evm and riscv64 machines. </span><br>Propose to remove the patch \
as it seams to fix the issue and I don't see any side effect after<div>testing \
it in some weeks.<br><br><a \
href="https://lists.openembedded.org/g/openembedded-core/message/171233">https://lists.openembedded.org/g/openembedded-core/message/171233</a><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Chen Qi <<a \
href="mailto:Qi.Chen@windriver.com" target="_blank">Qi.Chen@windriver.com</a>> \
escreveu no dia terça, 10/05/2022 à (s) 10:09:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div>
<div lang="EN-US">
<div>
<p class="MsoNormal">Hi All,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I met a regression after go was upgraded to \
1.18+.<u></u><u></u></p> <p class="MsoNormal">The problem can be reproduced by \
running `bitbake nativesdk-skopeo', with meta-virtualization added in \
bblayers.conf.<u></u><u></u></p> <p class="MsoNormal">The error message is as \
below.<u></u><u></u></p> <p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">"""<u></u><u></u></p>
<p class="MsoNormal"><snip><u></u><u></u></p>
<p class="MsoNormal">| HASH[build <a href="http://golang.org/x/text/unicode/norm" \
target="_blank">golang.org/x/text/unicode/norm</a>]: "import \"<a \
href="http://golang.org/x/text/unicode/norm%5C" \
target="_blank">golang.org/x/text/unicode/norm\</a>"\n"<u></u><u></u></p> \
<p class="MsoNormal">| HASH \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-skopeo/v<u></u><u></u></p>
<p class="MsoNormal">1.6.1+gitAUTOINC+3e2defd6d3-r0/git/src/import/vendor/<a \
href="http://github.com/pkg/errors/errors.go" \
target="_blank">github.com/pkg/errors/errors.go</a>: \
1b60ba5bcb417f0060d1c1fbc<u></u><u></u></p> <p \
class="MsoNormal">edaa1a702020499094ce8134f8b45a58c0ebbff<u></u><u></u></p> <p \
class="MsoNormal">| panic: runtime error: index out of range [0] with length \
0<u></u><u></u></p> <p class="MsoNormal">|<u></u><u></u></p>
<p class="MsoNormal">| goroutine 5129 [running]:<u></u><u></u></p>
<p class="MsoNormal">| cmd/go/internal/work.(*Builder).buildActionID(0xc0002490e0, \
0xc000370b40)<u></u><u></u></p> <p class="MsoNormal">| \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.<u></u><u></u></p>
<p class="MsoNormal">18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:281 \
+0x23cf<u></u><u></u></p> <p class="MsoNormal">| \
cmd/go/internal/work.(*Builder).build(0xc0002490e0, {0xc000220000?, 0x0?}, \
0xc000370b40)<u></u><u></u></p> <p class="MsoNormal">| \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.<u></u><u></u></p>
<p class="MsoNormal">18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:476 \
+0x199<u></u><u></u></p> <p class="MsoNormal">| \
cmd/go/internal/work.(*Builder).Do.func2({0xadd9f8, 0xc000220000}, \
0xc000370b40)<u></u><u></u></p> <p class="MsoNormal">| \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64 \
-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:139 \
+0x5ec<u></u><u></u></p> <p class="MsoNormal">| \
cmd/go/internal/work.(*Builder).Do.func3()<u></u><u></u></p> <p class="MsoNormal">| \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64 \
-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:201 \
+0xb9<u></u><u></u></p> <p class="MsoNormal">| created by \
cmd/go/internal/work.(*Builder).Do<u></u><u></u></p> <p class="MsoNormal">| \
/ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64 \
-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:187 \
+0x3da<u></u><u></u></p> <p class="MsoNormal">| Makefile:140: recipe for target \
'bin/skopeo' failed<u></u><u></u></p> <p \
class="MsoNormal"><snip><u></u><u></u></p> <p \
class="MsoNormal">"""<u></u><u></u></p> <p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I did some investigation and found it was related to a local \
patch, 0001-cmd-go-make-content-based-hash-generation-less-pedan.patch.<u></u><u></u></p>
<p class="MsoNormal">The build succeeded after I dropped this \
patch.<u></u><u></u></p> <p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I'm sending out this email to seek for some help, as I don't \
fully understand what this patch does.<u></u><u></u></p> <p class="MsoNormal"><u></u> \
<u></u></p> <p class="MsoNormal">e.g.<u></u><u></u></p>
<p class="MsoNormal">"""<u></u><u></u></p>
<p class="MsoNormal">+ if strings.HasPrefix(flag, \
"-m") {<u></u><u></u></p> <p class="MsoNormal">+ \
newflags = append(newflags, flag)<u></u><u></u></p> <p class="MsoNormal">+ \
}<u></u><u></u></p> <p class="MsoNormal">"""<u></u><u></u></p>
<p class="MsoNormal">This flag filtering is not explained in the commit \
message.<u></u><u></u></p> <p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">One more question: this patch applies to all go recipes, \
including go cross compilers and target go. But from its commit message, target go \
does not seem to need it.<u></u><u></u></p> <p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Any suggestion?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Regards,<u></u><u></u></p>
<p class="MsoNormal">Qi<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<br>
<br>
<br>
</div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div \
dir="ltr">Best regards,<div><br>José Quaresma</div></div></div></div></div></div>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171239): https://lists.openembedded.org/g/openembedded-core/message/171239
Mute This Topic: https://lists.openembedded.org/mt/91008732/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic