[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 2/2] cve-check: hook cleanup to the BuildCompleted event, not CookerExit
From:       "Marta Rybczynska" <rybczynska () gmail ! com>
Date:       2022-06-30 16:03:51
Message-ID: CAApg2=SJFOXKL3yrJzMfEY-7hDdzgLNrBJKTsR2HPmZQav9sdg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Jun 29, 2022 at 5:45 PM Ross Burton <ross.burton@arm.com> wrote:

>
> > On 29 Jun 2022, at 16:19, Marta Rybczynska <rybczynska@gmail.com> wrote=
:
> > Sean, could you check if it is your case too? I'll be adding a more
> verbose error message
> > so that we know which package it comes from.
>
> I actually think we should get rid of the index file entirely. Why can=E2=
=80=99t
> the big JSON file simply be all of the written JSON files merged together
> (by simply listing the directory contents)?
>
> Without the index file I was running into the issue of merging fragment
files from different builds
in the same directory (different images, the world build etc). I can see
the following solutions:
1. Move the fragment files to a separate directory and remove it at the
build end. It would work if nobody if using fragment files.
2. Extract the complete list of the packages build in a different way and
get fragment files using that different list.

Opinions?

Regards,
Marta

[Attachment #5 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, Jun 29, 2022 at 5:45 PM Ross Burton &lt;<a \
href="mailto:ross.burton@arm.com">ross.burton@arm.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> &gt; On 29 Jun \
2022, at 16:19, Marta Rybczynska &lt;<a href="mailto:rybczynska@gmail.com" \
target="_blank">rybczynska@gmail.com</a>&gt; wrote:<br> &gt; Sean, could you check if \
it is your case too? I&#39;ll be adding a more verbose error message<br> &gt; so that \
we know which package it comes from.<br> <br>
I actually think we should get rid of the index file entirely. Why can't the big JSON \
file simply be all of the written JSON files merged together (by simply listing the \
directory contents)?<br> <br></blockquote><div>Without the index file I was running \
into the issue of merging fragment files from different builds</div><div>in the same \
directory (different images, the world build etc). I can see the following \
solutions:</div><div>1. Move the fragment files to a separate directory and remove it \
at the build end. It would work if nobody <span class="ng" \
style="background:rgba(0,0,0,0) none repeat scroll 0% 0%!important">if using</span> \
fragment files.<br></div><div>2. Extract the complete list of the packages <span \
class="ng" style="background:rgba(0,0,0,0) none repeat scroll 0% \
0%!important">build</span> in a different way and get fragment files using that \
different list.</div><div><br></div><div>Opinions?</div><div><br></div><div>Regards,</div><div>Marta<br></div></div></div>




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167414): https://lists.openembedded.org/g/openembedded-core/message/167414
Mute This Topic: https://lists.openembedded.org/mt/92067057/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]