[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [oe-core][PATCH v2] libavtp: add recipe to be able to use aaf config for alsa-plugins
From: "Khem Raj" <raj.khem () gmail ! com>
Date: 2022-05-31 20:59:29
Message-ID: CAMKF1sovAcX5=tqV0vn7eBpq1cgV0z8gXNURX3sCWr20TcuGbw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, May 31, 2022 at 1:14 PM Marcel Ziswiler <marcel.ziswiler@toradex.com>
wrote:
> On Tue, 2022-05-31 at 12:01 -0700, Khem Raj wrote:
> > Maybe call the recipe avtp
>
> No, here I disagree. As mentioned before the project and everything is
> really called libavtp everywhere. So I
> think the better solution is to consistently use libavtp in
> openembedded-core everywhere as well.
That's fine with me I don't have hard stand on the name changing existing
packageconfog can be a change for someone who might be using it already but
that's fine we have warnings in place to address these
>
>
>
> > On Tue, May 31, 2022 at 11:36 AM Peter Bergin <peter@berginkonsult.se>
> wrote:
> > > Hi,
> > >
> > > thanks Marcel for bumping this patch again!
> > >
> > > On 2022-05-31 18:38, Khem Raj wrote:
> > > > On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <marcel@ziswiler.com>
> wrote:
> > > > > From: Peter Bergin <peter@berginkonsult.se>
> > > > >
> > > > > In order to enable configuration option aaf (AVTP Audio Format)
> > > > > used for AVB the library libavtp is a dependency but no recipe for
> > > > > this library was present. aaf support for alsa-plugins was
> > > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.
> > > > >
> > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se>
> > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > > >
> > > > > ---
> > > > > Resurrect from mailing list [1] as this is still not upstream.
> > > > > End-to-end tested on Verdin iMX8M Plus.
> > > > > Will talk about it at the Embedded World in the TSN & Linux track
> next
> > > > > month [2].
> > > > >
> > > > > [1]
> https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
> > > > > [2]
> https://events.weka-fachmedien.de/embedded-world-conference/program/
> > > > >
> > > > > Changes in v2:
> > > > > - Updated SRC_URI specifying mandatory protocol as https.
> > > > > - Updated SRCREV to latest.
> > > > >
> > > > > meta/recipes-multimedia/libavtp/libavtp_git.bb | 16
> ++++++++++++++++
> > > > There was a 0.2.0 release
> https://github.com/Avnu/libavtp/releases/tag/v0.2.0
> > > > so I wonder if we should use the release tagged SRC_URI and call the
> PV = 0.2.0
> > > This tag was set after I sent my initial patch. I think this is a good
> > > thing to do.
> > > >
> > > > > 1 file changed, 16 insertions(+)
> > > > > create mode 100644 meta/recipes-multimedia/libavtp/
> libavtp_git.bb
> > > > >
> > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb
> b/meta/recipes-
> > > > > multimedia/libavtp/libavtp_git.bb
> > > > > new file mode 100644
> > > > > index 0000000000..aefbee56ea
> > > > > --- /dev/null
> > > > > +++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> > > > > @@ -0,0 +1,16 @@
> > > > > +DESCRIPTION = "Open source implementation of Audio Video
> Transport Protocol (AVTP) \
> > > > > + specified in IEEE 1722-2016 spec."
> > > > > +HOMEPAGE = "https://github.com/Avnu/libavtp"
> > > > > +LICENSE = "BSD-3-Clause"
> > > > > +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
> > > > > +
> > > > > +PROVIDES = "avtp"
> > > > why is this provides needed ?
> > >
> > > It is because recipe meta/recipes-multimedia/alsa/
> alsa-plugins_1.2.6.bb
> > > has this PACKAGECONFIG:
> > >
> > > PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"
> > >
> > > So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?
> > >
> > > /Peter
> > >
> > > > > +
> > > > > +SRC_URI = "git://
> github.com/Avnu/libavtp.git;branch=master;protocol=https"
> > > > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
> > > > > +
> > > > > +S = "${WORKDIR}/git"
> > > > > +
> > > > > +inherit meson pkgconfig
> > > > > +
> > > > > +EXTRA_OEMESON = "-Dtests=disabled"
> > > > > --
> > > > > 2.36.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
>
[Attachment #5 (text/html)]
<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Tue, May 31, 2022 at 1:14 PM Marcel Ziswiler <<a \
href="mailto:marcel.ziswiler@toradex.com">marcel.ziswiler@toradex.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 2022-05-31 at 12:01 -0700, \
Khem Raj wrote:<br> > Maybe call the recipe avtp<br>
<br>
No, here I disagree. As mentioned before the project and everything is really called \
libavtp everywhere. So I<br> think the better solution is to consistently use libavtp \
in openembedded-core everywhere as well.</blockquote><div dir="auto"><br></div><div \
dir="auto">That's fine with me I don't have hard stand on the name changing existing \
packageconfog can be a change for someone who might be using it already but that's \
fine we have warnings in place to address these </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex" dir="auto"><br> <br>
<br>
> On Tue, May 31, 2022 at 11:36 AM Peter Bergin <<a \
href="mailto:peter@berginkonsult.se" target="_blank">peter@berginkonsult.se</a>> \
wrote:<br> > > Hi,<br>
> > <br>
> > thanks Marcel for bumping this patch again!<br>
> > <br>
> > On 2022-05-31 18:38, Khem Raj wrote:<br>
> > > On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <<a \
href="mailto:marcel@ziswiler.com" target="_blank">marcel@ziswiler.com</a>> \
wrote:<br> > > > > From: Peter Bergin <<a \
href="mailto:peter@berginkonsult.se" \
target="_blank">peter@berginkonsult.se</a>><br> > > > > <br>
> > > > In order to enable configuration option aaf (AVTP Audio \
Format)<br> > > > > used for AVB the library libavtp is a dependency but \
no recipe for<br> > > > > this library was present. aaf support for \
alsa-plugins was<br> > > > > introduced in \
ddf5421331180bc45697511b44cdd4a4e6dda6ff.<br> > > > > <br>
> > > > Signed-off-by: Peter Bergin <<a \
href="mailto:peter@berginkonsult.se" \
target="_blank">peter@berginkonsult.se</a>><br> > > > > Signed-off-by: \
Marcel Ziswiler <<a href="mailto:marcel.ziswiler@toradex.com" \
target="_blank">marcel.ziswiler@toradex.com</a>><br> > > > > <br>
> > > > ---<br>
> > > > Resurrect from mailing list [1] as this is still not \
upstream.<br> > > > > End-to-end tested on Verdin iMX8M Plus.<br>
> > > > Will talk about it at the Embedded World in the TSN & Linux \
track next<br> > > > > month [2].<br>
> > > > <br>
> > > > [1] <a \
href="https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/" \
rel="noreferrer" target="_blank">https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/</a><br>
> > > > [2] <a \
href="https://events.weka-fachmedien.de/embedded-world-conference/program/" \
rel="noreferrer" target="_blank">https://events.weka-fachmedien.de/embedded-world-conference/program/</a><br>
> > > > <br>
> > > > Changes in v2:<br>
> > > > - Updated SRC_URI specifying mandatory protocol as https.<br>
> > > > - Updated SRCREV to latest.<br>
> > > > <br>
> > > > meta/recipes-multimedia/libavtp/<a \
href="http://libavtp_git.bb" rel="noreferrer" target="_blank">libavtp_git.bb</a> | 16 \
++++++++++++++++<br> > > > There was a 0.2.0 release <a \
href="https://github.com/Avnu/libavtp/releases/tag/v0.2.0" rel="noreferrer" \
target="_blank">https://github.com/Avnu/libavtp/releases/tag/v0.2.0</a><br> > > \
> so I wonder if we should use the release tagged SRC_URI and call the PV = \
0.2.0<br> > > This tag was set after I sent my initial patch. I think this is a \
good <br> > > thing to do.<br>
> > > <br>
> > > > 1 file changed, 16 insertions(+)<br>
> > > > create mode 100644 meta/recipes-multimedia/libavtp/<a \
href="http://libavtp_git.bb" rel="noreferrer" target="_blank">libavtp_git.bb</a><br> \
> > > > <br> > > > > diff --git \
a/meta/recipes-multimedia/libavtp/<a href="http://libavtp_git.bb" rel="noreferrer" \
target="_blank">libavtp_git.bb</a> b/meta/recipes-<br> > > > > \
multimedia/libavtp/<a href="http://libavtp_git.bb" rel="noreferrer" \
target="_blank">libavtp_git.bb</a><br> > > > > new file mode 100644<br>
> > > > index 0000000000..aefbee56ea<br>
> > > > --- /dev/null<br>
> > > > +++ b/meta/recipes-multimedia/libavtp/<a \
href="http://libavtp_git.bb" rel="noreferrer" target="_blank">libavtp_git.bb</a><br> \
> > > > @@ -0,0 +1,16 @@<br> > > > > +DESCRIPTION = \
"Open source implementation of Audio Video Transport Protocol (AVTP) \<br> > \
> > > + specified in IEEE 1722-2016 spec."<br> \
> > > > +HOMEPAGE = "<a href="https://github.com/Avnu/libavtp" \
rel="noreferrer" target="_blank">https://github.com/Avnu/libavtp</a>"<br> > \
> > > +LICENSE = "BSD-3-Clause"<br> > > > > \
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"<br>
> > > > +<br>
> > > > +PROVIDES = "avtp"<br>
> > > why is this provides needed ?<br>
> > <br>
> > It is because recipe meta/recipes-multimedia/alsa/<a \
href="http://alsa-plugins_1.2.6.bb" rel="noreferrer" \
target="_blank">alsa-plugins_1.2.6.bb</a> <br> > > has this PACKAGECONFIG:<br>
> > <br>
> > PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"<br>
> > <br>
> > So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?<br>
> > <br>
> > /Peter<br>
> > <br>
> > > > +<br>
> > > > +SRC_URI = "git://<a \
href="http://github.com/Avnu/libavtp.git;branch=master;protocol=https" \
rel="noreferrer" target="_blank">github.com/Avnu/libavtp.git;branch=master;protocol=https</a>"<br>
> > > > +SRCREV = \
"3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"<br> > > > > +<br>
> > > > +S = "${WORKDIR}/git"<br>
> > > > +<br>
> > > > +inherit meson pkgconfig<br>
> > > > +<br>
> > > > +EXTRA_OEMESON = "-Dtests=disabled"<br>
> > > > --<br>
> > > > 2.36.1<br>
> > > > <br>
> > > > <br>
> > > > <br>
> > > > <br>
> > > > <br>
> > > > <br>
</blockquote></div></div>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#166334): https://lists.openembedded.org/g/openembedded-core/message/166334
Mute This Topic: https://lists.openembedded.org/mt/91454504/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic