[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] image.bbclass: allow overriding dependency on virtual/kernel:do_deploy
From:       "Jacob Kroon" <jacob.kroon () gmail ! com>
Date:       2022-04-29 20:53:45
Message-ID: 98ed4653-93a0-2559-c6ab-4054b1c43be6 () gmail ! com
[Download RAW message or body]

On 4/27/22 09:37, Dmitry Baryshkov wrote:
> Since the commit fe26b2379ecd ("image.bbclass: Depend on
> virtual/kernel:do_deploy"), the image.bbclass made building images
> depend on virtual/kernel. For some images, including small initramfs,
> this is not the case. Allow overriding this dependency in case
> developers knows what they are doing.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  meta/classes/image.bbclass | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 7f1f6f80a464..47776db2b0e6 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -132,7 +132,12 @@ def rootfs_variables(d):
>  
>  do_rootfs[vardeps] += "${@rootfs_variables(d)}"
>  
> -do_build[depends] += "virtual/kernel:do_deploy"
> +# This is needed to have kernel image in DEPLOY_DIR.
> +# This follow many common usecases and user expectations.
> +# But if you are building an image which doesn't need the kernel image at all,
> +# you can unset this variable manually.
> +KERNELDEPLOYDEPEND ?= "virtual/kernel:do_deploy"
> +do_build[depends] += "${KERNELDEPMODDEPEND}"
>  

I saw this got merged to master.

The patch doesn't make sense.

It sets

KERNELDEPLOYDEPEND

then uses

KERNELDEPMODDEPEND

?

And please make it readable by adding some underscores, like

KERNEL_DEPLOY_DEPEND

Jacob


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#165058): https://lists.openembedded.org/g/openembedded-core/message/165058
Mute This Topic: https://lists.openembedded.org/mt/90726077/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]